[update] the surface size to use a tuple.

Author: vmarcella

crates/lambda-platform/src/gfx/framebuffer.rs

@@ -1,11 +1,6 @@
-use std::borrow::Borrow;
-
 use gfx_hal::{
   device::Device,
-  image::{
-    Extent,
-    FramebufferAttachment,
-  },
+  image::Extent,
 };
 
 use super::{
@@ -43,6 +38,7 @@ impl FramebufferBuilder {
     return Self {};
   }
 
+  /// Build a frame buffer on a given GPU for the given surface.
   pub fn build<RenderBackend: gfx_hal::Backend>(
     self,
     gpu: &mut Gpu<RenderBackend>,
@@ -51,7 +47,7 @@ impl FramebufferBuilder {
   ) -> Framebuffer<RenderBackend> {
     use super::surface::internal::frame_buffer_attachment_from;
 
-    let [width, height] = surface.size().expect("A surface without a swapchain cannot be used in a framebeen configured with a swapchain");
+    let (width, height) = surface.size().expect("A surface without a swapchain cannot be used in a framebeen configured with a swapchain");
     let image = frame_buffer_attachment_from(surface).unwrap();
 
     let frame_buffer = unsafe {

crates/lambda-platform/src/gfx/surface.rs

@@ -238,9 +238,9 @@ impl<RenderBackend: gfx_hal::Backend> Surface<RenderBackend> {
 
   /// Get the size of the surface's extent. Will only return a size if a
   /// swapchain has been applied to the surface to render with.
-  pub fn size(&self) -> Option<[u32; 2]> {
+  pub fn size(&self) -> Option<(u32, u32)> {
     return match self.extent {
-      Some(extent) => Some([extent.width, extent.height]),
+      Some(extent) => Some((extent.width, extent.height)),
       None => None,
     };
   }
@@ -249,16 +249,16 @@ impl<RenderBackend: gfx_hal::Backend> Surface<RenderBackend> {
 // ------------------------------ SWAPCHAIN BUILDER ----------------------------
 
 pub struct SwapchainBuilder {
-  size: [u32; 2],
+  size: (u32, u32),
 }
 
 impl SwapchainBuilder {
   pub fn new() -> Self {
-    return Self { size: [480, 360] };
+    return Self { size: (480, 360) };
   }
 
   pub fn with_size(mut self, width: u32, height: u32) -> Self {
-    self.size = [width, height];
+    self.size = (width, height);
     return self;
   }
 
@@ -270,14 +270,12 @@ impl SwapchainBuilder {
     let physical_device = super::gpu::internal::physical_device_for(gpu);
     let caps = surface.gfx_hal_surface.capabilities(physical_device);
     let format = internal::get_first_supported_format(surface, physical_device);
+    let (width, height) = self.size;
 
     let mut swapchain_config = gfx_hal::window::SwapchainConfig::from_caps(
       &caps,
       format,
-      gfx_hal::window::Extent2D {
-        width: self.size[0],
-        height: self.size[1],
-      },
+      gfx_hal::window::Extent2D { width, height },
     );
 
     // TODO(vmarcella) Profile the performance on MacOS to see if this slows

lambda/src/core/render/mod.rs

@@ -264,13 +264,13 @@ impl RenderContext {
 
   /// Allocates a command buffer and records commands to the GPU.
   pub fn render(&mut self, commands: Vec<RenderCommand>) {
-    let dimensions = self
+    let (width, height) = self
       .surface
       .size()
       .expect("Surface has no size configured.");
 
     let swapchain = SwapchainBuilder::new()
-      .with_size(dimensions[0], dimensions[1])
+      .with_size(width, height)
       .build(&self.gpu, &self.surface);
 
     Rc::get_mut(&mut self.surface)