[fix] warnings inside of lambda-rs.

Author: vmarcella

crates/lambda-rs/examples/reflective_room.rs

@@ -214,22 +214,20 @@ impl Component<ComponentResult, String> for ReflectiveRoomExample {
   }
 
   fn on_window_event(&mut self, event: &WindowEvent) -> Result<(), String> {
-    match event {
-      WindowEvent::Resize { width, height } => {
-        self.width = *width;
-        self.height = *height;
-      }
-      _ => {}
+    if let WindowEvent::Resize { width, height } = event {
+      self.width = *width;
+      self.height = *height;
     }
     return Ok(());
   }
 
   fn on_keyboard_event(&mut self, event: &Key) -> Result<(), String> {
-    match event {
-      Key::Pressed {
-        scan_code: _,
-        virtual_key,
-      } => match virtual_key {
+    if let Key::Pressed {
+      scan_code: _,
+      virtual_key,
+    } = event
+    {
+      match virtual_key {
         Some(VirtualKey::KeyM) => {
           self.msaa_samples = if self.msaa_samples > 1 { 1 } else { 4 };
           self.needs_rebuild = true;
@@ -272,8 +270,7 @@ impl Component<ComponentResult, String> for ReflectiveRoomExample {
           );
         }
         _ => {}
-      },
-      _ => {}
+      }
     }
     return Ok(());
   }
@@ -625,9 +622,7 @@ impl ReflectiveRoomExample {
         .with_immediate_data(immediate_data_size)
         .with_buffer(
           BufferBuilder::new()
-            .with_length(
-              floor_mesh.vertices().len() * std::mem::size_of::<Vertex>(),
-            )
+            .with_length(std::mem::size_of_val(floor_mesh.vertices()))
             .with_usage(Usage::VERTEX)
             .with_properties(Properties::DEVICE_LOCAL)
             .with_buffer_type(BufferType::Vertex)
@@ -677,9 +672,7 @@ impl ReflectiveRoomExample {
         .with_immediate_data(immediate_data_size)
         .with_buffer(
           BufferBuilder::new()
-            .with_length(
-              cube_mesh.vertices().len() * std::mem::size_of::<Vertex>(),
-            )
+            .with_length(std::mem::size_of_val(cube_mesh.vertices()))
             .with_usage(Usage::VERTEX)
             .with_properties(Properties::DEVICE_LOCAL)
             .with_buffer_type(BufferType::Vertex)
@@ -730,9 +723,7 @@ impl ReflectiveRoomExample {
       .with_immediate_data(immediate_data_size)
       .with_buffer(
         BufferBuilder::new()
-          .with_length(
-            floor_mesh.vertices().len() * std::mem::size_of::<Vertex>(),
-          )
+          .with_length(std::mem::size_of_val(floor_mesh.vertices()))
           .with_usage(Usage::VERTEX)
           .with_properties(Properties::DEVICE_LOCAL)
           .with_buffer_type(BufferType::Vertex)
@@ -768,9 +759,7 @@ impl ReflectiveRoomExample {
       .with_immediate_data(immediate_data_size)
       .with_buffer(
         BufferBuilder::new()
-          .with_length(
-            cube_mesh.vertices().len() * std::mem::size_of::<Vertex>(),
-          )
+          .with_length(std::mem::size_of_val(cube_mesh.vertices()))
           .with_usage(Usage::VERTEX)
           .with_properties(Properties::DEVICE_LOCAL)
           .with_buffer_type(BufferType::Vertex)

crates/lambda-rs/src/render/mod.rs

@@ -1057,8 +1057,7 @@ mod tests {
   fn immediates_validate_pipeline_exists_rejects_unknown_pipeline() {
     let pipelines: Vec<RenderPipeline> = vec![];
     let err = RenderContext::validate_pipeline_exists(&pipelines, 7)
-      .err()
-      .expect("must error");
+      .expect_err("must error");
     assert!(err.to_string().contains("Unknown pipeline 7"));
   }
 }

crates/lambda-rs/src/render/validation.rs

@@ -144,9 +144,10 @@ mod tests {
 
   #[test]
   fn validate_instance_range_rejects_negative_length() {
-    let err = validate_instance_range("Draw", &(5..1))
-      .err()
-      .expect("must error");
+    let start = 5_u32;
+    let end = 1_u32;
+    let err =
+      validate_instance_range("Draw", &(start..end)).expect_err("must error");
     assert!(err.contains("Draw instance range start 5 is greater than end 1"));
   }
 

crates/lambda-rs/src/runtimes/application.rs

@@ -553,8 +553,10 @@ mod tests {
 
   #[test]
   fn dispatch_skips_component_when_mask_is_none() {
-    let mut component = RecordingComponent::default();
-    component.mask = EventMask::NONE;
+    let mut component = RecordingComponent {
+      mask: EventMask::NONE,
+      ..Default::default()
+    };
 
     let event = Events::Window {
       event: WindowEvent::Close,
@@ -569,8 +571,10 @@ mod tests {
 
   #[test]
   fn dispatch_skips_component_when_mask_does_not_contain_event() {
-    let mut component = RecordingComponent::default();
-    component.mask = EventMask::KEYBOARD;
+    let mut component = RecordingComponent {
+      mask: EventMask::KEYBOARD,
+      ..Default::default()
+    };
 
     let event = Events::Window {
       event: WindowEvent::Close,
@@ -586,8 +590,10 @@ mod tests {
 
   #[test]
   fn dispatch_calls_exact_handler_when_mask_contains_event() {
-    let mut component = RecordingComponent::default();
-    component.mask = EventMask::WINDOW | EventMask::KEYBOARD;
+    let mut component = RecordingComponent {
+      mask: EventMask::WINDOW | EventMask::KEYBOARD,
+      ..Default::default()
+    };
 
     let window_event = Events::Window {
       event: WindowEvent::Resize {
@@ -630,9 +636,11 @@ mod tests {
 
   #[test]
   fn dispatch_returns_fatal_error_message_on_handler_failure() {
-    let mut component = RecordingComponent::default();
-    component.mask = EventMask::WINDOW;
-    component.fail_window = true;
+    let mut component = RecordingComponent {
+      mask: EventMask::WINDOW,
+      fail_window: true,
+      ..Default::default()
+    };
 
     let event = Events::Window {
       event: WindowEvent::Close,