Skip to content

Commit 4dec81c

Browse files
committed
[update] rendering to occur within the redraw event.
1 parent 13a5885 commit 4dec81c

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

crates/lambda-platform/src/gfx/render_pass.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl SubpassBuilder {
125125
};
126126
}
127127

128-
pub fn use_color_attachment(
128+
pub fn with_color_attachment(
129129
mut self,
130130
attachment_index: usize,
131131
layout: ImageLayoutHint,

lambda/src/core/component.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ pub trait RenderableComponent<E>: Component<E> {
1919
fn on_render(
2020
&mut self,
2121
render_context: &mut super::render::RenderContext,
22-
last_render: &Duration,
2322
) -> Vec<super::render::command::RenderCommand>;
2423
fn on_renderer_detached(
2524
&mut self,

lambda/src/runtimes/mod.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,17 +260,19 @@ impl Runtime for GenericRuntime {
260260
current_frame = Instant::now();
261261
let duration = &current_frame.duration_since(last_frame);
262262

263-
let render_api = active_render_context.as_mut().unwrap();
264263
// Update and render commands.
265264
for component in &mut component_stack {
266265
component.on_update(duration);
267-
let commands = component.on_render(render_api, duration);
268-
render_api.render(commands);
269266
}
270267

271268
window.redraw();
272269
}
273-
WinitEvent::RedrawRequested(_) => {}
270+
WinitEvent::RedrawRequested(_) => {
271+
for component in &mut component_stack {
272+
let commands = component.on_render(active_render_context.as_mut().unwrap());
273+
active_render_context.as_mut().unwrap().render(commands);
274+
}
275+
}
274276
WinitEvent::NewEvents(_) => {}
275277
WinitEvent::DeviceEvent { device_id, event } => {}
276278
WinitEvent::UserEvent(lambda_event) => match lambda_event {

tools/lambda_rs_demo/src/main.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ impl RenderableComponent<Events> for DemoComponent {
136136
fn on_render(
137137
self: &mut DemoComponent,
138138
_render_context: &mut lambda::core::render::RenderContext,
139-
_last_render: &std::time::Duration,
140139
) -> Vec<RenderCommand> {
141140
let viewport =
142141
viewport::ViewportBuilder::new().build(self.width, self.height);

0 commit comments

Comments
 (0)