Skip to content

Commit ec5a19a

Browse files
committed
feat: logic change, isomorphism only done if isomorphism is selected through params
1 parent 223b962 commit ec5a19a

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

evaluation_function/evaluation.py

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -647,17 +647,11 @@ def _err(msg: str) -> Result:
647647
try:
648648
p = EvaluationParams.model_validate(raw_params)
649649
except ValidationError as e:
650-
if ans.graph is None:
651-
return _err(
652-
"Invalid params schema. Expected e.g. "
653-
"{'evaluation_type': 'connectivity'|'bipartite'|'graph_coloring'|...}. "
654-
f"Error: {e}"
655-
f"\n response_dict: {response_dict}"
656-
f"\n answer_dict: {answer_dict}"
657-
f"\n response: {response}"
658-
f"\n answer: {answer}"
659-
f"\n params: {params}"
660-
)
650+
return _err(
651+
"Invalid params schema. Expected e.g. "
652+
"{'evaluation_type': 'connectivity'|'bipartite'|'graph_coloring'|...}. "
653+
f"Error: {e}"
654+
)
661655

662656
# ── resolve graphs ───────────────────────────────────────────────────
663657
# student_graph (resp.graph) is always present — the student submits a graph.
@@ -911,11 +905,7 @@ def _eval_clique_number() -> Result:
911905
"clique_number": _eval_clique_number,
912906
}
913907

914-
# If answer graph is provided, run isomorphism check regardless of params
915-
if ans.graph is not None:
916-
return _eval_isomorphism()
917-
918-
# Otherwise use the evaluation type from params
908+
# Always use the evaluation type from params
919909
handler = dispatch.get(p.evaluation_type)
920910
if handler is None:
921911
return _err(f"Unsupported evaluation_type: '{p.evaluation_type}'.")

0 commit comments

Comments
 (0)