Skip to content

Commit 0224415

Browse files
committed
fix: fix return stuff
1 parent dda4c9e commit 0224415

2 files changed

Lines changed: 28 additions & 27 deletions

File tree

evaluation_function/evaluation.py

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -398,29 +398,30 @@ def _generate_feedback(
398398

399399
overall_message = "✓ Correct! Your algorithm meets the complexity requirements." if is_correct else "✗ Your algorithm does not meet the complexity requirements."
400400

401-
# Time complexity section
402-
time_feedback = None
403-
if time_result:
404-
time_feedback = {
405-
"required": time_result.expected_answer,
406-
"detected": time_result.detected_complexity,
407-
"is_correct": time_result.is_correct,
408-
"message": "✓ Your algorithm meets the time complexity requirement."
409-
if time_result.is_correct
410-
else "✗ Your algorithm exceeds the allowed time complexity."
411-
}
412-
413-
# Space complexity section
414-
space_feedback = None
415-
if space_result:
416-
space_feedback = {
417-
"required": space_result.expected_answer,
418-
"detected": space_result.detected_complexity,
419-
"is_correct": space_result.is_correct,
420-
"message": "✓ Your algorithm meets the space complexity requirement."
421-
if space_result.is_correct
422-
else "✗ Your algorithm exceeds the allowed space complexity."
423-
}
401+
# # Time complexity section
402+
# time_feedback = None
403+
# if time_result:
404+
# time_feedback = TimeComplexityResult(
405+
# student_answer=
406+
# required=time_result.expected_answer,
407+
# detected=time_result.detected_complexity,
408+
# is_correct=time_result.is_correct,
409+
# message="✓ Your algorithm meets the time complexity requirement."
410+
# if time_result.is_correct
411+
# else "✗ Your algorithm exceeds the allowed time complexity."
412+
# )
413+
414+
# # Space complexity section
415+
# space_feedback = None
416+
# if space_result:
417+
# space_feedback = SpaceComplexityResult(
418+
# required=space_result.expected_answer,
419+
# detected=space_result.detected_complexity,
420+
# is_correct=space_result.is_correct,
421+
# message="✓ Your algorithm meets the space complexity requirement."
422+
# if space_result.is_correct
423+
# else "✗ Your algorithm exceeds the allowed space complexity."
424+
# )
424425

425426
# Test cases section
426427
test_case_feedback = [
@@ -445,8 +446,8 @@ def _generate_feedback(
445446
return EvaluationResult(
446447
is_correct=is_correct,
447448
overall_message=overall_message,
448-
time_complexity=time_feedback,
449-
space_complexity=space_feedback,
449+
time_complexity=time_result,
450+
space_complexity=space_result,
450451
test_cases=test_case_feedback,
451452
detailed_sections=detailed_sections
452453
)

evaluation_function/schemas/output_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class SectionFeedback(BaseModel):
209209
class EvaluationResult(BaseModel):
210210
is_correct: bool
211211
overall_message: str
212-
time_complexity: dict = Field(default_factory=dict)
213-
space_complexity: dict = Field(default_factory=dict)
212+
time_complexity: Optional[TimeComplexityResult] = Field(default=None)
213+
space_complexity: Optional[SpaceComplexityResult] = Field(default=None)
214214
test_cases: List[TestCaseFeedback] = Field(default_factory=list)
215215
detailed_sections: List[SectionFeedback] = Field(default_factory=list)

0 commit comments

Comments
 (0)