Create a new exception instead of wrapping it

Author: emyfops

src/main/java/com/lambda/mixin/CrashReportMixin.java

@@ -21,7 +21,7 @@
 import com.lambda.config.AbstractSetting;
 import com.lambda.module.Module;
 import com.lambda.module.ModuleRegistry;
-import com.lambda.util.DynamicException;
+import com.lambda.util.DynamicExceptionKt;
 import com.llamalad7.mixinextras.injector.wrapmethod.WrapMethod;
 import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
 import net.minecraft.client.MinecraftClient;
@@ -47,7 +47,7 @@ public class CrashReportMixin {
     @Inject(method = "<init>(Ljava/lang/String;Ljava/lang/Throwable;)V", at = @At("TAIL"))
     void injectConstructor(String message, Throwable cause, CallbackInfo ci) {
         if (!Lambda.INSTANCE.isDebug() && MinecraftClient.getInstance() != null) {
-            this.cause = new DynamicException(cause);
+            this.cause = DynamicExceptionKt.dynamicException(cause);
         }
     }
 

src/main/kotlin/com/lambda/util/DynamicException.kt

@@ -18,29 +18,19 @@
 package com.lambda.util
 
 import com.lambda.util.DynamicReflectionSerializer.simpleRemappedName
-import java.io.PrintStream
-import java.io.PrintWriter
+import kotlin.collections.toTypedArray
 
-class DynamicException(original: Throwable) : Throwable(original) {
-    private fun Array<StackTraceElement>.remapClassNames() =
-        map { element ->
+/**
+ * Remaps the stacktrace in production to have readable, class, method and field names
+ */
+fun dynamicException(original: Throwable) = Throwable(original.localizedMessage)
+    .apply {
+        stackTrace = stackTrace.map { element ->
             StackTraceElement(
                 element.className.simpleRemappedName,
                 element.methodName.simpleRemappedName,
-                element.fileName,
+                element.fileName, // This is intentional, you don't need to remap the file name so might as well keep a reference of the class file name
                 element.lineNumber
             )
         }.toTypedArray()
-
-    override fun printStackTrace(s: PrintStream) =
-        stackTrace.forEach { s.println("\tat $it") }
-
-    override fun printStackTrace(s: PrintWriter) =
-        stackTrace.forEach { s.println("\tat $it") }
-
-    override fun toString(): String = localizedMessage
-
-    init {
-        stackTrace = stackTrace.remapClassNames()
-    }
-}
+    }