check for buffer access flags

Author: emyfops

common/src/main/kotlin/com/lambda/graphics/buffer/IBuffer.kt

@@ -134,7 +134,7 @@ interface IBuffer {
         data: ByteBuffer,
         offset: Long,
     ): Throwable? {
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferBound(target))
@@ -152,7 +152,7 @@ interface IBuffer {
      * @param data The data to put in the new allocated buffer
      */
     fun allocate(data: ByteBuffer): Throwable? {
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferUsageValid(usage))
@@ -172,7 +172,7 @@ interface IBuffer {
      * @param size The size of the new buffer
      */
     fun allocate(size: Long): Throwable? {
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferUsageValid(usage))
@@ -191,7 +191,7 @@ interface IBuffer {
      * This function handles the buffer binding
      */
     fun storage(data: ByteBuffer): Throwable? {
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferUsageValid(usage))
@@ -212,7 +212,7 @@ interface IBuffer {
      * @param size The size of the storage buffer
      */
     fun storage(size: Long): Throwable? {
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferUsageValid(usage))
@@ -243,7 +243,7 @@ interface IBuffer {
             size < 0
         ) return IllegalArgumentException("Invalid offset or size parameter offset: $offset size: $size")
 
-        if (!bufferValid(target))
+        if (!bufferValid(target, access))
             return IllegalArgumentException("Target is not valid. Refer to the table in the documentation")
 
         if (!bufferBound(target))

common/src/main/kotlin/com/lambda/graphics/gl/Buffers.kt

@@ -43,7 +43,12 @@ val bindingCheckMappings = mapOf(
 /**
  * Returns whether the buffer target is valid
  */
-fun bufferValid(target: Int): Boolean = target in bindingCheckMappings
+fun bufferValid(target: Int, access: Int): Boolean =
+    target in bindingCheckMappings &&
+            // If access contains GL_MAP_COHERENT_BIT, it must also contain GL_MAP_PERSISTENT_BIT.
+            (access and GL_MAP_COHERENT_BIT   == 0 || access and GL_MAP_PERSISTENT_BIT != 0) &&
+            // If access contains GL_MAP_PERSISTENT_BIT, it must also contain at least one of GL_MAP_READ_BIT or GL_MAP_WRITE_BIT.
+            (access and GL_MAP_PERSISTENT_BIT == 0 || (access and (GL_MAP_READ_BIT or GL_MAP_WRITE_BIT) != 0))
 
 /**
  * Returns whether the provided buffer target is bound