Better shulker placements and solve TaskFlow memory leak

Author: Avanatiker

src/main/java/com/lambda/mixin/render/DebugHudMixin.java

@@ -17,7 +17,6 @@
 
 package com.lambda.mixin.render;
 
-import com.lambda.task.RootTask;
 import com.lambda.util.DebugInfoHud;
 import net.minecraft.client.gui.hud.DebugHud;
 import org.spongepowered.asm.mixin.Mixin;
@@ -33,9 +32,4 @@ public class DebugHudMixin {
     private void onGetRightText(CallbackInfoReturnable<List<String>> cir) {
         DebugInfoHud.addDebugInfo(cir.getReturnValue());
     }
-
-    @Inject(method = "getLeftText", at = @At("TAIL"))
-    private void onGetLeftText(CallbackInfoReturnable<List<String>> cir) {
-        cir.getReturnValue().addAll(List.of(RootTask.INSTANCE.toString().split("\n")));
-    }
 }

src/main/kotlin/com/lambda/config/groups/EatConfig.kt

@@ -18,7 +18,6 @@
 package com.lambda.config.groups
 
 import com.lambda.context.SafeContext
-import com.lambda.interaction.material.StackSelection
 import com.lambda.interaction.material.StackSelection.Companion.selectStack
 import com.lambda.threading.runSafe
 import com.lambda.util.Describable
@@ -32,13 +31,16 @@ interface EatConfig {
     val eatOnHunger: Boolean
     val minFoodLevel: Int
     val nutritiousFood: List<Item>
-    val selectionPriority: SelectionPriority
     val saturated: Saturation
+
     val eatOnFire: Boolean
     val resistanceFood: List<Item>
+
     val eatOnDamage: Boolean
     val minDamage: Int
     val regenerationFood: List<Item>
+
+    val selectionPriority: SelectionPriority
     val ignoreBadFood: Boolean
     val badFood: List<Item>
 
@@ -67,7 +69,7 @@ interface EatConfig {
     }
 
     enum class Reason(val message: (ItemStack) -> String) {
-        None({ "Waiting for food to eat..." }),
+        None({ "Waiting for reason to eat..." }),
         Hunger({ "Eating ${it.item.name.string} due to Hunger" }),
         Damage({ "Eating ${it.item.name.string} due to Damage" }),
         Fire({ "Eating ${it.item.name.string} due to Fire" });

src/main/kotlin/com/lambda/task/Task.kt

@@ -23,6 +23,7 @@ import com.lambda.event.EventFlow.unsubscribe
 import com.lambda.event.Muteable
 import com.lambda.event.events.TickEvent
 import com.lambda.event.listener.SafeListener.Companion.listen
+import com.lambda.module.modules.client.TaskFlowModule
 import com.lambda.threading.runSafe
 import com.lambda.util.Communication.logError
 import com.lambda.util.Nameable
@@ -126,6 +127,7 @@ abstract class Task<Result> : Nameable, Muteable {
     fun success(result: Result) {
         unsubscribe()
         state = State.COMPLETED
+        if (!TaskFlowModule.showAllEntries) parent?.subTasks?.remove(this)
         runSafe {
             executeNextTask(result)
         }

src/main/kotlin/com/lambda/task/tasks/PlaceContainer.kt

@@ -36,6 +36,7 @@ import com.lambda.task.tasks.BuildTask.Companion.build
 import com.lambda.util.BlockUtils.blockPos
 import com.lambda.util.BlockUtils.blockState
 import com.lambda.util.item.ItemUtils.shulkerBoxes
+import com.lambda.util.math.distSq
 import net.minecraft.block.ChestBlock
 import net.minecraft.entity.mob.ShulkerEntity
 import net.minecraft.item.ItemStack
@@ -72,7 +73,7 @@ class PlaceContainer @Ta5kBuilder constructor(
         val containerPosition = options.filter {
             // ToDo: Check based on if we can move the player close enough rather than y level once the custom pathfinder is merged
             it.blockPos.y == player.blockPos.y
-        }.minOrNull()?.blockPos ?: run {
+        }.minByOrNull { it.blockPos distSq player.pos }?.blockPos ?: run {
             failure("Couldn't find a valid container placement position for ${startStack.name.string}")
             return@onStart
         }