Log error instead of propagate

Author: emyfops

common/src/main/kotlin/com/lambda/command/commands/CapeCommand.kt

@@ -17,16 +17,15 @@
 
 package com.lambda.command.commands
 
-import com.lambda.brigadier.CommandResult.Companion.success
+import com.lambda.brigadier.argument.literal
 import com.lambda.brigadier.argument.string
 import com.lambda.brigadier.argument.value
-import com.lambda.brigadier.executeWithResult
+import com.lambda.brigadier.execute
 import com.lambda.brigadier.required
 import com.lambda.command.LambdaCommand
 import com.lambda.network.CapeManager.updateCape
 import com.lambda.network.NetworkManager
 import com.lambda.threading.runSafe
-import com.lambda.util.Communication.info
 import com.lambda.util.extension.CommandBuilder
 
 object CapeCommand : LambdaCommand(
@@ -35,27 +34,21 @@ object CapeCommand : LambdaCommand(
     description = "Sets your cape",
 )  {
     override fun CommandBuilder.create() {
-        required(string("id")) { id ->
-            suggests { _, builder ->
-                NetworkManager.capes
-                    .forEach { builder.suggest(it) }
+        required(literal("set")) {
+            required(string("id")) { id ->
+                suggests { _, builder ->
+                    NetworkManager.capes
+                        .forEach { builder.suggest(it) }
 
-                builder.buildFuture()
-            }
-
-            executeWithResult {
-                runSafe {
-                    val cape = id().value()
-
-                    // FixMe:
-                    //  try-catch is stupid -
-                    //  cannot propagate errors correctly -
-                    //  spam the user and fuck off
-                    updateCape(cape)
-                    this@CapeCommand.info("Successfully updated the cape")
+                    builder.buildFuture()
+                }
 
-                    success()
-                }!!
+                execute {
+                    runSafe {
+                        val cape = id().value()
+                        updateCape(cape)
+                    }
+                }
             }
         }
     }

common/src/main/kotlin/com/lambda/network/CapeManager.kt

@@ -29,6 +29,7 @@ import com.lambda.network.api.v1.endpoints.getCape
 import com.lambda.network.api.v1.endpoints.setCape
 import com.lambda.network.api.v1.models.Cape
 import com.lambda.sound.SoundManager.toIdentifier
+import com.lambda.util.Communication.info
 import com.lambda.util.Communication.logError
 import com.lambda.util.FolderRegister.capes
 import com.lambda.util.extension.get
@@ -57,11 +58,11 @@ object CapeManager : ConcurrentHashMap<UUID, String>(), Loadable {
     /**
      * Sets the current player's cape
      */
-    fun SafeContext.updateCape(cape: String) =
+    fun SafeContext.updateCape(cape: String): CancellableRequest =
         setCape(cape,
-            success = { fetchCape(player.uuid) },
+            success = { fetchCape(player.uuid); info("Successfully update your cape to $cape") },
             failure = { logError("Could not update the player cape", it) }
-        )//.join()
+        )
 
     /**
      * Fetches the cape of the given player id