cleaned up some code

Author: emyfops

common/src/main/kotlin/com/lambda/interaction/request/breaking/BreakManager.kt

@@ -186,21 +186,23 @@ object BreakManager : RequestHandler<BreakRequest>(
 
         // Reversed so that the breaking order feels natural to the user as the primary break is always the
         // last break to be started
-        run breakInfos@ {
+        run {
             breakInfos
                 .filterNotNull()
                 .filter { !it.isRedundant }
-                .also { infos ->
-                    rotationRequest = infos.firstOrNull { it.breakConfig.rotateForBreak }?.let { info ->
-                        val rotation = info.context.rotation
-                        if (instantBreaks.isEmpty()) info.request.rotation.request(rotation, false) else rotation
-                    }
+                .also {
+                    rotationRequest = it.firstOrNull { it.breakConfig.rotateForBreak }
+                        ?.let { info ->
+                            val rotation = info.context.rotation
+                            if (instantBreaks.isEmpty()) info.request.rotation.request(rotation, false) else rotation
+                        }
                 }
-                .reversed()
+                .asReversed()
                 .forEach { info ->
-                    if (info.updatedProgressThisTick) return@forEach
-                    if (!info.context.requestDependencies(request)) return@breakInfos
-                    if ((!rotated && info.isPrimary) || tickStage !in info.breakConfig.breakStageMask) return@breakInfos
+                    if (info.updatedProgressThisTick) return@run
+                    if (!info.context.requestDependencies(request)) return@run
+                    if ((!rotated && info.isPrimary) || tickStage !in info.breakConfig.breakStageMask) return@run
+
                     updateBreakProgress(info)
                 }
         }
@@ -263,9 +265,10 @@ object BreakManager : RequestHandler<BreakRequest>(
     private fun SafeContext.canAccept(ctx: BreakContext): Boolean {
         if (pendingBreaks.any { it.context.expectedPos == ctx.expectedPos }) return false
 
-        breakInfos.firstOrNull { it != null && !it.isRedundant }
+        breakInfos
+            .firstOrNull { it != null && !it.isRedundant }
             ?.let { info ->
-                if ( ctx.hotbarIndex != info.context.hotbarIndex) return false
+                if (ctx.hotbarIndex != info.context.hotbarIndex) return false
             }
 
         return !blockState(ctx.expectedPos).isAir
@@ -641,4 +644,4 @@ object BreakManager : RequestHandler<BreakRequest>(
         }
 
     override fun preEvent(): Event = UpdateManagerEvent.Break().post()
-}
+}

common/src/main/kotlin/com/lambda/interaction/request/breaking/BreakRequest.kt

@@ -43,8 +43,6 @@ data class BreakRequest(
 ) : Request(prio, build.breaking) {
     override val done: Boolean
         get() = runSafe {
-            contexts.all {
-                ctx -> ctx.targetState.matches(blockState(ctx.expectedPos), ctx.expectedPos, world)
-            }
+            contexts.all { it.targetState.matches(blockState(it.expectedPos), it.expectedPos, world) }
         } == true
-}
+}

common/src/main/kotlin/com/lambda/interaction/request/hotbar/HotbarConfig.kt

@@ -21,7 +21,7 @@ import com.lambda.config.groups.TickStage
 import com.lambda.interaction.request.Priority
 import com.lambda.interaction.request.RequestConfig
 
-/*
+/**
  * Abstract base class for configuring hotbar slot switch behavior.
  *
  * @param priority The priority of this configuration.
@@ -67,4 +67,4 @@ abstract class HotbarConfig(
     override fun requestInternal(request: HotbarRequest, queueIfClosed: Boolean) {
         HotbarManager.request(request, queueIfClosed)
     }
-}
+}

common/src/main/kotlin/com/lambda/interaction/request/rotation/RotationConfig.kt

@@ -21,7 +21,7 @@ import com.lambda.config.groups.TickStage
 import com.lambda.interaction.request.Priority
 import com.lambda.interaction.request.RequestConfig
 
-/*
+/**
  * Abstract base class for configuring rotation behavior.
  *
  * @param priority The priority of this configuration.
@@ -68,4 +68,4 @@ abstract class RotationConfig(priority: Priority) : RequestConfig<RotationReques
         override val rotationStageMask = setOf(*TickStage.entries.toTypedArray())
         override val rotationMode = mode
     }
-}
+}

common/src/main/kotlin/com/lambda/interaction/request/rotation/visibilty/PointSelection.kt

@@ -20,22 +20,22 @@ package com.lambda.interaction.request.rotation.visibilty
 import com.lambda.interaction.request.rotation.Rotation.Companion.dist
 import com.lambda.interaction.request.rotation.RotationManager
 import com.lambda.util.math.distSq
+import com.lambda.util.math.times
 
 enum class PointSelection(val select: (MutableList<VisibilityChecker.CheckedHit>) -> VisibilityChecker.CheckedHit?) {
     ByRotation({ hits ->
         hits.minByOrNull {
             RotationManager.activeRotation dist it.targetRotation
         }
     }),
-    Optimum( optimum@ { hits ->
+    Optimum({ hits ->
         val optimum = hits
-            .map { it.hit.pos }.reduceOrNull { acc, vec3d ->
-                acc?.let { it.add(vec3d) } ?: acc
-            }
-            ?.multiply(1.0 / hits.size.toDouble()) ?: return@optimum null
+            .map { it.hit.pos }
+            .reduceOrNull { acc, pos -> acc.add(pos) }
+            ?.times(1 / hits.size)
 
-        hits.minByOrNull {
-            it.hit.pos distSq optimum
+        optimum?.let {
+            hits.minByOrNull { it.hit.pos distSq optimum }
         }
     })
-}
+}

common/src/main/kotlin/com/lambda/module/modules/player/PacketMine.kt

@@ -40,7 +40,7 @@ import net.minecraft.util.math.BlockPos
 import java.util.concurrent.ConcurrentLinkedQueue
 
 object PacketMine : Module(
-    "Packet Mine",
+    "PacketMine",
     "automatically breaks blocks, and does it faster",
     setOf(ModuleTag.PLAYER)
 ) {
@@ -116,4 +116,4 @@ object PacketMine : Module(
     enum class Page {
         Build, Rotation, Interaction, Inventory, Hotbar
     }
-}
+}