Merge branch 'master' into feature/packetmine-rewrite

# Conflicts:
#	common/src/main/java/com/lambda/mixin/MinecraftClientMixin.java

Author: beanbag44

.github/workflows/build.yml

@@ -3,60 +3,26 @@ name: Build Lambda
 on:
   push:
     branches:
-      - '**'
+      - 'master'
+  pull_request:
 
 jobs:
-  check-runner:
-    name: Check Runner Availability
-    runs-on: ubuntu-latest
-    
-    outputs:
-      runner-label: ${{ steps.set-runner.outputs.runner-label }}
-    
-    steps:
-      - name: Set runner
-        id: set-runner
-        run: |
-          runners=$(curl -v -s -H "Accept: application/vnd.github+json" -H "Authorization: token ${{ secrets.REPO_ACCESS_TOKEN }}" "https://api.github.com/repos/${{ github.repository }}/actions/runners" --http1.1)
-          if [ $? -ne 0 ]; then
-            echo "Error: Failed to fetch runners from GitHub API" >&2
-            exit 1
-          fi
-
-          runners_count=$(echo "$runners" | jq '.runners | length')
-          if [ "$runners_count" -eq 0 ]; then
-            echo "No runners available or failed to retrieve runners." >&2
-            echo "runner-label=ubuntu-latest" >> $GITHUB_OUTPUT
-            exit 0
-          fi
-    
-          available=$(echo "$runners" | jq '.runners[] | select(.status == "online" and .busy == false and .labels[] .name == "self-hosted")')
-          if [ $? -ne 0 ]; then
-            echo "Error: Failed to parse JSON response" >&2
-            exit 1
-          fi
-    
-          if [ -n "$available" ]; then
-            echo "runner-label=lambda-linux-runner" >> $GITHUB_OUTPUT
-          else
-            echo "runner-label=ubuntu-latest" >> $GITHUB_OUTPUT
-          fi
   build:
     concurrency:
       group: ${{ github.workflow }}-${{ github.ref }}
       cancel-in-progress: true
-
-    needs: check-runner
-    runs-on: ${{ needs.check-runner.outputs.runner-label }}
 
     name: Build Lambda
+    runs-on: ubuntu-latest
+
     permissions:
       contents: write
+
     env:
       SEGMENT_DOWNLOAD_TIMEOUT_MINS: '5'
     steps:
       - name: Checkout Repository
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4
 
       - name: Set current date as env variable
         run: echo "DATE=$(date +'%Y-%m-%dT%H:%M:%S')" >> $GITHUB_ENV
@@ -65,11 +31,11 @@ jobs:
         id: vars
         run: echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
 
-      - name: Set-Up JDK 17
+      - name: Set-Up JDK
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: '17'
+          java-version: '21'
           architecture: x64
           cache: 'gradle'
 
@@ -81,7 +47,7 @@ jobs:
           all: true
 
       - name: Build Lambda
-        run: ./gradlew build
+        run: ./gradlew build --no-daemon
 
       - name: Rename Files with Commit Hash
         run: |
@@ -111,8 +77,6 @@ jobs:
           ### [Lambda Forge ${{ steps.all.outputs.modVersion }} ${{ steps.all.outputs.minecraftVersion }} (${{ env.COMMIT_HASH }})](https://r2-bucket.edouard127.christmas/${{ env.DATE }}-${{ env.COMMIT_HASH }}/lambda-forge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}.jar)
           
           #### [API (Developer Dependency)](https://r2-bucket.edouard127.christmas/${{ env.DATE }}-${{ env.COMMIT_HASH }}/lambda-api-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}.jar)
-
-          **Runner:** \`${{ needs.check-runner.outputs.runner-label }}\`
           EOF
 
       - name: Failover Upload

.github/workflows/publish-docs.yml

@@ -2,8 +2,8 @@ name: Publish Dokka Documentation
 
 on:
   push:
-    branches:
-      - 'master'
+    tags:
+      - '*'
 
 jobs:
   build:

common/build.gradle.kts

@@ -23,6 +23,9 @@ val kotlinxCoroutinesVersion: String by project
 val discordIPCVersion: String by project
 val fuelVersion: String by project
 val resultVersion: String by project
+val mockitoKotlin: String by project
+val mockitoInline: String by project
+val mockkVersion: String by project
 
 base.archivesName = "${base.archivesName.get()}-api"
 
@@ -57,6 +60,10 @@ dependencies {
 
     // Baritone
     modImplementation("baritone-api:baritone-unoptimized-fabric:1.10.2") { isTransitive = false }
+    testImplementation(kotlin("test"))
+    testImplementation("org.mockito.kotlin:mockito-kotlin:$mockitoKotlin")
+    testImplementation("org.mockito:mockito-inline:$mockitoInline")
+    testImplementation("io.mockk:mockk:${mockkVersion}")
 }
 
 tasks {
@@ -66,5 +73,12 @@ tasks {
 
     test {
         useJUnitPlatform()
+        jvmArgs("-XX:+EnableDynamicAgentLoading", "-Xshare:off")
+    }
+}
+
+tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
+    kotlinOptions {
+        jvmTarget = "17"
     }
 }

common/src/main/java/com/lambda/mixin/MinecraftClientMixin.java

@@ -29,6 +29,7 @@
 import net.minecraft.client.gui.screen.ingame.ScreenHandlerProvider;
 import net.minecraft.client.network.ClientPlayerEntity;
 import net.minecraft.client.network.ClientPlayerInteractionManager;
+import net.minecraft.util.thread.ThreadExecutor;
 import net.minecraft.util.Hand;
 import net.minecraft.util.hit.HitResult;
 import org.jetbrains.annotations.Nullable;
@@ -74,7 +75,7 @@ private void onShutdown(CallbackInfo ci) {
     }
 
     /**
-     * Inject after the thread field is set so `ThreadExecutor#getThread` is available
+     * Inject after the thread field is set so that {@link ThreadExecutor#getThread} is available
      */
     @Inject(at = @At(value = "FIELD", target = "Lnet/minecraft/client/MinecraftClient;thread:Ljava/lang/Thread;", shift = At.Shift.AFTER, ordinal = 0), method = "run")
     private void onStartup(CallbackInfo ci) {

common/src/main/java/com/lambda/mixin/entity/ClientPlayInteractionManagerMixin.java

@@ -25,6 +25,7 @@
 import net.minecraft.entity.Entity;
 import net.minecraft.entity.player.PlayerEntity;
 import net.minecraft.entity.player.PlayerInventory;
+import net.minecraft.network.packet.c2s.play.UpdateSelectedSlotC2SPacket;
 import net.minecraft.screen.slot.SlotActionType;
 import net.minecraft.util.ActionResult;
 import net.minecraft.util.Hand;
@@ -86,6 +87,18 @@ public void clickSlotHead(int syncId, int slotId, int button, SlotActionType act
         if (EventFlow.post(click).isCanceled()) ci.cancel();
     }
 
+    /**
+     * Posts {@link InventoryEvent.HotbarSlot.Update} and returns the event value as the selected slot
+     * <pre>{@code
+     * private void syncSelectedSlot() {
+     *     int i = this.client.player.getInventory().selectedSlot;
+     *     if (i != this.lastSelectedSlot) {
+     *         this.lastSelectedSlot = i;
+     *         this.networkHandler.sendPacket(new UpdateSelectedSlotC2SPacket(this.lastSelectedSlot));
+     *     }
+     * }
+     * }</pre>
+     */
     @Redirect(method = "syncSelectedSlot", at = @At(value = "FIELD", target = "Lnet/minecraft/entity/player/PlayerInventory;selectedSlot:I"))
     public int overrideSelectedSlotSync(PlayerInventory instance) {
         return EventFlow.post(new InventoryEvent.HotbarSlot.Update(instance.selectedSlot)).getSlot();

common/src/main/java/com/lambda/mixin/entity/ClientPlayerEntityMixin.java

@@ -50,6 +50,9 @@ public abstract class ClientPlayerEntityMixin extends EntityMixin {
     @Shadow
     protected abstract void autoJump(float dx, float dz);
 
+    /**
+     * Post movement events and applies the modified player velocity
+     */
     @Inject(method = "move", at = @At("HEAD"), cancellable = true)
     void onMove(MovementType movementType, Vec3d movement, CallbackInfo ci) {
         ClientPlayerEntity self = (ClientPlayerEntity) (Object) this;
@@ -78,6 +81,22 @@ void processMovement(Input input, boolean slowDown, float slowDownFactor) {
         EventFlow.post(new MovementEvent.InputUpdate(input, slowDown, slowDownFactor));
     }
 
+    /**
+     * Posts the {@link MovementEvent.Sprint} event
+     * <pre>{@code
+     * if (this.isSprinting()) {
+     *     boolean bl8 = !this.input.hasForwardMovement() || !this.canSprint();
+     *     boolean bl9 = bl8 || this.horizontalCollision && !this.collidedSoftly || this.isTouchingWater() && !this.isSubmergedInWater();
+     *     if (this.isSwimming()) {
+     *         if (!this.isOnGround() && !this.input.sneaking && bl8 || !this.isTouchingWater()) {
+     *             this.setSprinting(false);
+     *         }
+     *     } else if (bl9) {
+     *         this.setSprinting(false);
+     *     }
+     * }
+     * }</pre>
+     */
     @Redirect(method = "tickMovement", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/ClientPlayerEntity;isSprinting()Z"))
     boolean isSprinting(ClientPlayerEntity entity) {
         return EventFlow.post(new MovementEvent.Sprint(entity.isSprinting())).getSprint();
@@ -92,6 +111,9 @@ void redirectSneaking(CallbackInfoReturnable<Boolean> cir) {
         cir.setReturnValue(EventFlow.post(new MovementEvent.Sneak(self.input.sneaking)).getSneak());
     }
 
+    /**
+     * Overwrites the movement packet update function to use our code
+     */
     @Inject(method = "sendMovementPackets", at = @At(value = "HEAD"), cancellable = true)
     void sendBegin(CallbackInfo ci) {
         ci.cancel();
@@ -121,8 +143,6 @@ float fixHeldItemPitch(ClientPlayerEntity instance) {
 
     @Inject(method = "damage", at = @At("HEAD"), cancellable = true)
     public void damage(DamageSource source, float amount, CallbackInfoReturnable<Boolean> cir) {
-        if (EventFlow.post(new PlayerEvent.Damage(source, amount)).isCanceled()) {
-            cir.setReturnValue(false);
-        }
+        if (EventFlow.post(new PlayerEvent.Damage(source, amount)).isCanceled()) cir.setReturnValue(false);
     }
 }

common/src/main/java/com/lambda/mixin/entity/EntityMixin.java

@@ -45,6 +45,9 @@ public void move(MovementType movementType, Vec3d movement) {
     @Shadow
     public abstract float getYaw();
 
+    /**
+     * Modifies the player yaw when there is an active rotation to apply the player velocity correctly
+     */
     @Redirect(method = "updateVelocity", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/Entity;getYaw()F"))
     public float velocityYaw(Entity entity) {
         if ((Object) this != Lambda.getMc().player) return getYaw();
@@ -55,6 +58,14 @@ public float velocityYaw(Entity entity) {
         return y;
     }
 
+    /**
+     * Modifies the player yaw for the given tick delta for interpolation when there is an active rotation
+     * <pre>{@code
+     * public final Vec3d getRotationVec(float tickDelta) {
+     *     return this.getRotationVector(this.getPitch(tickDelta), this.getYaw(tickDelta));
+     * }
+     * }</pre>
+     */
     @Redirect(method = "getRotationVec", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/Entity;getYaw(F)F"))
     float fixDirectionYaw(Entity entity, float tickDelta) {
         Vec2d rot = RotationManager.getRotationForVector(tickDelta);
@@ -63,6 +74,14 @@ float fixDirectionYaw(Entity entity, float tickDelta) {
         return (float) rot.getX();
     }
 
+    /**
+     * Modifies the player pitch for the given tick delta for interpolation when there is an active rotation
+     * <pre>{@code
+     * public final Vec3d getRotationVec(float tickDelta) {
+     *     return this.getRotationVector(this.getPitch(tickDelta), this.getYaw(tickDelta));
+     * }
+     * }</pre>
+     */
     @Redirect(method = "getRotationVec", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/Entity;getPitch(F)F"))
     float fixDirectionPitch(Entity entity, float tickDelta) {
         Vec2d rot = RotationManager.getRotationForVector(tickDelta);
@@ -71,6 +90,14 @@ float fixDirectionPitch(Entity entity, float tickDelta) {
         return (float) rot.getY();
     }
 
+    /**
+     * Modifies the player yaw for the current rotation yaw
+     * <pre>{@code
+     * public Vec3d getRotationVector() {
+     * 	return this.getRotationVector(this.getPitch(), this.getYaw());
+     * }
+     * }</pre>
+     */
     @Redirect(method = "getRotationVector()Lnet/minecraft/util/math/Vec3d;", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/Entity;getYaw()F"))
     float fixDirectionYaw2(Entity entity) {
         Vec2d rot = RotationManager.getRotationForVector(1.0);
@@ -79,6 +106,14 @@ float fixDirectionYaw2(Entity entity) {
         return (float) rot.getX();
     }
 
+    /**
+     * Modifies the player yaw for the current rotation pitch
+     * <pre>{@code
+     * public Vec3d getRotationVector() {
+     * 	return this.getRotationVector(this.getPitch(), this.getYaw());
+     * }
+     * }</pre>
+     */
     @Redirect(method = "getRotationVector()Lnet/minecraft/util/math/Vec3d;", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/Entity;getPitch()F"))
     float fixDirectionPitch2(Entity entity) {
         Vec2d rot = RotationManager.getRotationForVector(1.0);
@@ -95,7 +130,6 @@ private void changeLookDirection(double cursorDeltaX, double cursorDeltaY, Callb
     @Inject(method = "onTrackedDataSet(Lnet/minecraft/entity/data/TrackedData;)V", at = @At("TAIL"))
     public void onTrackedDataSet(TrackedData<?> data, CallbackInfo ci) {
         Entity entity = (Entity) (Object) this;
-
         EventFlow.post(new EntityEvent.EntityUpdate(entity, data));
     }
 

common/src/main/java/com/lambda/mixin/entity/FireworkRocketEntityMixin.java

@@ -27,16 +27,10 @@
 
 @Mixin(FireworkRocketEntity.class)
 public class FireworkRocketEntityMixin {
-    @Redirect(
-            method = "tick",
-            at = @At(
-                    value = "INVOKE",
-                    target = "Lnet/minecraft/entity/LivingEntity;setVelocity(Lnet/minecraft/util/math/Vec3d;)V"
-            )
-    )
+    @Redirect(method = "tick", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/LivingEntity;setVelocity(Lnet/minecraft/util/math/Vec3d;)V"))
     private void redirectSetVelocity(LivingEntity shooter, Vec3d vec3d) {
         if (ElytraFly.getDoBoost()) {
-            ElytraFly.boostRocket(shooter);
+            ElytraFly.boostRocket();
         } else shooter.setVelocity(vec3d);
     }
 }