check all other position blocking managers when accepting action requests

Author: beanbag44

common/src/main/kotlin/com/lambda/interaction/request/ManagerUtils.kt

@@ -18,8 +18,13 @@
 package com.lambda.interaction.request
 
 import com.lambda.util.reflections.getInstances
+import net.minecraft.util.math.BlockPos
 
 object ManagerUtils {
     val managers = getInstances<RequestHandler<*>>()
     val accumulatedManagerPriority = managers.map { it.stagePriority }.reduce { acc, priority -> acc + priority }
+    val positionBlockingManagers = getInstances<PositionBlocking>()
+
+    fun isPosBlocked(pos: BlockPos) =
+        positionBlockingManagers.any { manager -> manager.blockedPositions.any { blocked -> blocked == pos } }
 }

common/src/main/kotlin/com/lambda/interaction/request/breaking/BreakManager.kt

@@ -31,6 +31,7 @@ import com.lambda.event.listener.UnsafeListener.Companion.listenUnsafe
 import com.lambda.graphics.renderer.esp.builders.buildFilled
 import com.lambda.graphics.renderer.esp.builders.buildOutline
 import com.lambda.interaction.construction.context.BreakContext
+import com.lambda.interaction.request.ManagerUtils.isPosBlocked
 import com.lambda.interaction.request.PositionBlocking
 import com.lambda.interaction.request.Priority
 import com.lambda.interaction.request.RequestHandler
@@ -352,7 +353,7 @@ object BreakManager : RequestHandler<BreakRequest>(
      * @return if the break context can be accepted.
      */
     private fun SafeContext.canAccept(ctx: BreakContext, breakConfig: BreakConfig): Boolean {
-        if (pendingBreaks.any { it.context.blockPos == ctx.blockPos }) return false
+        if (isPosBlocked(ctx.blockPos)) return false
 
         if (breakConfig.doubleBreak) {
             breakInfos

common/src/main/kotlin/com/lambda/interaction/request/interacting/InteractionManager.kt

@@ -25,6 +25,8 @@ import com.lambda.event.events.TickEvent
 import com.lambda.event.events.UpdateManagerEvent
 import com.lambda.event.listener.SafeListener.Companion.listen
 import com.lambda.interaction.construction.context.InteractionContext
+import com.lambda.interaction.request.ManagerUtils.isPosBlocked
+import com.lambda.interaction.request.PositionBlocking
 import com.lambda.interaction.request.RequestHandler
 import com.lambda.interaction.request.breaking.BreakManager
 import com.lambda.interaction.request.interacting.InteractedBlockHandler.addPendingInteract
@@ -44,13 +46,16 @@ object InteractionManager : RequestHandler<InteractionRequest>(
     TickEvent.Input.Post,
     TickEvent.Player.Post,
     onOpen = { activeRequest?.let { processRequest(it) } }
-) {
+), PositionBlocking {
     private var activeRequest: InteractionRequest? = null
     private var potentialInteractions = mutableListOf<InteractionContext>()
 
     private var interactionsThisTick = 0
     private var maxInteractionsThisTick = 0
 
+    override val blockedPositions
+        get() = pendingInteractions.map { it.context.blockPos }
+
     init {
         listen<TickEvent.Post>(priority = Int.MIN_VALUE) {
             activeRequest = null
@@ -107,7 +112,7 @@ object InteractionManager : RequestHandler<InteractionRequest>(
     private fun populateFrom(request: InteractionRequest) {
         setPendingConfigs(request)
         potentialInteractions = request.contexts
-            .filter { pendingInteractions.none { pending -> pending.context.blockPos == it.blockPos } }
+            .filter { !isPosBlocked(it.blockPos) }
             .toMutableList()
 
         val pendingLimit =  (request.build.maxPendingInteractions - pendingPlacements.size).coerceAtLeast(0)

common/src/main/kotlin/com/lambda/interaction/request/placing/PlaceManager.kt

@@ -25,6 +25,7 @@ import com.lambda.event.events.TickEvent
 import com.lambda.event.events.UpdateManagerEvent
 import com.lambda.event.listener.SafeListener.Companion.listen
 import com.lambda.interaction.construction.context.PlaceContext
+import com.lambda.interaction.request.ManagerUtils.isPosBlocked
 import com.lambda.interaction.request.PositionBlocking
 import com.lambda.interaction.request.Priority
 import com.lambda.interaction.request.RequestHandler
@@ -156,28 +157,20 @@ object PlaceManager : RequestHandler<PlaceRequest>(
      * Filters the [request]'s [PlaceContext]s, placing them into the [potentialPlacements] collection, and
      * setting the maxPlacementsThisTick value.
      *
-     * @see canPlace
+     * @see isPosBlocked
      */
     private fun populateFrom(request: PlaceRequest) {
         val place = request.build.placing
 
         setPendingConfigs(request)
         potentialPlacements = request.contexts
-            .filter { canPlace(it) }
+            .filter { !isPosBlocked(it.blockPos) }
             .toMutableList()
 
         val pendingLimit =  (place.maxPendingPlacements - pendingPlacements.size).coerceAtLeast(0)
         maxPlacementsThisTick = (place.placementsPerTick.coerceAtMost(pendingLimit))
     }
 
-    /**
-     * @return if none of the [pendingPlacements] match positions with the [placeContext]
-     */
-    private fun canPlace(placeContext: PlaceContext) =
-        pendingPlacements.none { pending ->
-            pending.context.blockPos == placeContext.blockPos
-        }
-
     /**
      * A modified version of the minecraft interactBlock method, renamed to better suit its usage.
      *