Alpha module list by anoipm · Pull Request #2884 · kyma-project/cli

anoipm · 2026-04-15T18:49:19Z

Description

Changes proposed in this pull request:

add (alpha/v2) module list command

Related issue(s)
See also:

[CLI modules v2] kyma alpha module list #2819

github-actions · 2026-04-15T18:52:36Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify / standards (pull_request_target) action.

github-actions · 2026-05-14T19:39:07Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

…uleInstallation

github-actions · 2026-05-14T20:58:13Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

musztardem · 2026-05-15T14:03:15Z

+	for i, status := range kymaCR.Status.Modules {
+		raw := kyma.KymaModuleInfo{Status: status}
+		for _, spec := range kymaCR.Spec.Modules {
+			if spec.Name == status.Name {
+				raw.Spec = spec
+				break
+			}
+		}


Module entry in kyma.spec.modules comes from a user and the entry in status is populated by the lifecycle manager. When lifecycle manager fails somehow and won't populate the status we might lose information that user wanted to enable the module (i.e. module will be present in spec and will be missing in status). I'm not saying it's very probable scenario but I think it's safer to iterate over the module spec in the first place

Ok, I've just realized that when we remove entry from the spec then we are still going to have entry in the status as it's going to be in Deleting state for some time, so it goes both ways:

user adds entry in the spec - for some time we might have entry only in the spec and not in status before lifecycle manager gets to reconcile the module

user removes entry from the spec - then for some time we have entry only in the status as it's in the Deleting state

So I believe we should iterate separately the status and spec collections and compose the result

musztardem · 2026-05-18T09:50:24Z

+			ModuleState:          module.ModuleState,
+			Managed:              module.IsManaged(),
+			CustomResourcePolicy: module.CustomResourcePolicy,
+			InstallationState:    installationState,


With that approach we've detached the installationState from the moduleInstallation. I think the installationState should live in the moduleInstallation and population of it's value should be handled in the NewModuleInstallationFromRaw.

musztardem · 2026-05-18T09:54:16Z

+	return &moduleInstallationStateRepository{kubeClient: kubeClient}
+}
+
+func (r *moduleInstallationStateRepository) GetInstallationState(ctx context.Context, module entities.ModuleInstallation) (string, error) {


This is implementation of a separate repository for a single string value that I believe should live in the ModuleInstallation as the installation state belongs to the moduleInstallation. I see however that there's lot of extraction logic that might bloat the original repository.

I think we could introduce some kind of extractors or converters package that could live in the repository package that could have specialized classes responsible for such data transformations

musztardem · 2026-05-18T10:09:54Z

There's some discrepancy in how module list and alpha module list work for managed modules, there's output from my console:

$ ./bin/kyma alpha module list
MODULE                  VERSION               CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
api-gateway             3.6.2(regular)        CreateAndDelete   true      Ready           Ready
application-connector   1.3.1(fast)           CreateAndDelete   true      Ready           Ready
btp-operator            1.3.2(regular)        CreateAndDelete   true      Ready           Ready
cap-operator            0.28.0(fast)          CreateAndDelete   true      Ready           Ready
cfapi                   0.4.0(experimental)   CreateAndDelete   true      Ready           Ready
cloud-manager           1.7.1(fast)           CreateAndDelete   true      Ready           Ready
connectivity-proxy      1.2.2(fast)           CreateAndDelete   true      Ready           Ready
eventing                1.5.3(fast)           CreateAndDelete   true      Deleting        Deleting
istio                   1.26.7(regular)       CreateAndDelete   true      Ready           Ready
keda                    1.10.1(fast)          CreateAndDelete   true      Ready           Ready
nats                    1.5.2(fast)           CreateAndDelete   true      Deleting        Deleting
serverless              1.12.0(fast)          CreateAndDelete   true      Ready           Ready
telemetry               1.63.3(fast)          CreateAndDelete   true      Ready           Ready
transparent-proxy       1.9.5(fast)           CreateAndDelete   true      Ready           Ready
ztis-agent              0.28.0(fast)          CreateAndDelete   true      Ready           Ready
[12:03:07] [cost 0.409s] ./bin/kyma alpha module list

$ ./bin/kyma module list
2026-05-18T10:05:11.442219Z	info	klog	Waited before sending request	delay=1.1237515s reason=client-side throttling, not priority and fairness verb=GET URL=https://api.ee0bdf1.stage.kyma.ondemand.com/apis/operator.kyma-project.io/v1beta2/namespaces/kyma-system/moduletemplates/istio-1.26.7
NAME                    VERSION               CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
api-gateway             3.6.2(regular)        CreateAndDelete   true      Ready           Ready
application-connector   1.3.1(fast)           CreateAndDelete   true      Ready           Ready
btp-operator            1.3.2(regular)        CreateAndDelete   true      Ready           Ready
cap-operator            0.28.0(fast)          CreateAndDelete   true      Ready           Ready
cfapi                   0.4.0(experimental)   CreateAndDelete   true      Ready           Ready
cloud-manager           1.7.1(fast)           CreateAndDelete   true      Ready           Ready
connectivity-proxy      1.2.2(fast)           CreateAndDelete   true      Ready           Ready
eventing                1.5.3(fast)           CreateAndDelete   true                      Deleting
istio                   1.26.7(regular)       CreateAndDelete   true      Warning         Ready
keda                    1.10.1(fast)          CreateAndDelete   true      Warning         Ready
nats                    1.5.2(fast)           CreateAndDelete   true      Warning         Deleting
serverless              1.12.0(fast)          CreateAndDelete   true      Ready           Ready
telemetry               1.63.3(fast)          CreateAndDelete   true      Ready           Ready
transparent-proxy       1.9.5(fast)           CreateAndDelete   true      Ready           Ready
ztis-agent              0.28.0(fast)          CreateAndDelete   true      Error           Ready
docker-registry         0.13.0                N/A               false     Ready           Ready
registry-proxy          0.14.0                N/A               false     Ready           Ready
[12:05:16] [cost 7.593s] ./bin/kyma module list

…solveInstallationState

…sitory

github-actions · 2026-05-19T20:29:14Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

anoipm added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2026

anoipm requested a review from a team as a code owner April 15, 2026 18:49

anoipm requested a review from a team as a code owner April 15, 2026 19:07

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/repository/installedmodules.go Outdated

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/repository/moduleinstallationstate.go Outdated

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/list.go Outdated

anoipm added 22 commits May 14, 2026 22:52

add kyma alpha module list stub

4ff0af1

add under construction note to list cmd help

8e102f8

add ListService with InstalledModulesRepository

2e31d0b

ListService returns core modules from InstalledModulesRepository

f242fb0

wire ListService to list command, print module names

62a21c5

add version and channel to ListResult

4f9b46d

render list as table with module, version, channel columns

6e0e58b

update generated docs for alpha module list

220cba9

add output format support to list command (table, json)

1bb69cb

add yaml output format to list command

e3ba089

extract convertListToOutputFormat

740ebf1

extract convertListToRows

68d3601

add -o output format flag to list command

788d323

sort list results by name

599568d

add state field to ListResult

f2b057f

add state field to list rendering

0125e18

change InstalledModulesRepository to return KymaModuleInfo

08115d3

add managed field to ListResult

fc8fdd1

add managed field to list rendering

9c8402a

add customResourcePolicy field to ListResult

4eb76fa

add customResourcePolicy field to list rendering

066d3a7

align list table columns with ADR-003

cf01b8d

anoipm added 8 commits May 14, 2026 22:52

add installation state via ModuleInstallationStateRepository

ccae3f6

render installationState in all output formats

63a2121

combine module and installation status when they differ

98f16b7

update list command description

006cf36

align JSON/YAML keys with column names

1733e52

rename State to ModuleState in ListResult

b628dc7

introduce ModuleInstallation entity, move business logic to service

c54fe54

replace Template field with TemplateName and TemplateNamespace in Mod…

f8c347b

…uleInstallation

anoipm force-pushed the alpha-module-list branch from 7e24e9e to f8c347b Compare May 14, 2026 20:57

musztardem reviewed May 15, 2026

View reviewed changes

anoipm removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026

musztardem self-assigned this May 18, 2026

musztardem reviewed May 18, 2026

View reviewed changes

anoipm added 6 commits May 19, 2026 12:18

merge spec and status when listing installed modules

a859512

add IsBeingDeleted to ModuleInstallation, handle deleting state in re…

b426c92

…solveInstallationState

add ModuleCRStateRepository to fetch module state from CR

ab788c6

handle unmanaged modules in ModuleCRStateRepository

0da83f5

log discovery errors instead of propagating them in ModuleCRStateRepo…

6a5c288

…sitory

simplify installationStatus rendering - show InstallationState directly

ef844ae

anoipm assigned anoipm and unassigned musztardem May 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alpha module list#2884

Alpha module list#2884
anoipm wants to merge 36 commits into
kyma-project:mainfrom
anoipm:alpha-module-list

anoipm commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

musztardem May 15, 2026

Uh oh!

musztardem May 18, 2026

Uh oh!

musztardem May 18, 2026

Uh oh!

musztardem May 18, 2026 •

edited

Loading

Uh oh!

musztardem commented May 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

anoipm commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Proposed changes verification passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 14, 2026

✅ Proposed changes verification passed

Uh oh!

musztardem May 15, 2026

Choose a reason for hiding this comment

Uh oh!

musztardem May 18, 2026

Choose a reason for hiding this comment

Uh oh!

musztardem May 18, 2026

Choose a reason for hiding this comment

Uh oh!

musztardem May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musztardem commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

✅ Proposed changes verification passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 15, 2026 •

edited

Loading

musztardem May 18, 2026 •

edited

Loading

musztardem commented May 18, 2026 •

edited

Loading