-
Notifications
You must be signed in to change notification settings - Fork 5.1k
WIP: Fix KVM + CRI-O test failures: use cni0 bridge and skip preload test #22054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: divysinghvi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @divysinghvi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
/ok-to-test |
| } | ||
|
|
||
| if ContainerRuntime() == "crio" { | ||
| t.Skipf("skipping %s - user-pulled images not persisted across restarts with crio", t.Name()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add link to documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
| { | ||
| "type": "bridge", | ||
| "bridge": "bridge", | ||
| "bridge": "cni0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we are changing this for everyeone all runtimes ? can you add more contexts maybe Before/AFter this PR
and also maybe this could be Two Prs for two different test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was experimenting with something it did not work will remove this
|
@divysinghvi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
kvm2 driver with docker runtime Times for minikube start: 43.7s 42.8s 41.0s 43.0s 42.6s Times for minikube ingress: 16.8s 15.8s 16.3s 15.8s 16.3s docker driver with docker runtime Times for minikube ingress: 10.6s 41.1s 10.6s 10.6s 10.6s Times for minikube start: 23.0s 23.0s 21.9s 20.5s 24.4s docker driver with containerd runtime Times for minikube ingress: 20.1s 20.1s 21.1s 20.1s 21.1s Times for minikube start: 17.9s 21.5s 19.4s 20.5s 22.6s |
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
Fix KVM + CRI-O test failures: use cni0 bridge and skip preload test