Skip to content

Conversation

@welteki
Copy link

@welteki welteki commented Nov 27, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds Slicer as a new cloud provider to the Kubernetes Autoscaler. Slicer is a lightweight microVM platform. It offers a convenient, commercially supported way for running Kubernetes on Firecracker microVMs on bare-metal and on-premises infrastructure.

Integrating Slicer into the Autoscaler allows users to dynamically scale their Kubernetes clusters on bare-metal and on-premises infrastructure

Key highlights:

  • Implements the CloudProvider, NodeGroup interfaces specific to Slicer microVMs
  • Supports scale up/down using the Slicer's REST API for microVM lifecycle management

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The initial version covers scale-up and scale-down functionality.

Does this PR introduce a user-facing change?

Slicer has been added as a supported cloud provider in Kubernetes Cluster Autoscaler.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Other doc]: https://docs.slicervm.com/examples/autoscaling-k3s/

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @welteki!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @welteki. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: welteki
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/helm-charts size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area labels Nov 27, 2025
@welteki welteki force-pushed the slicer-provider branch 2 times, most recently from 6d10e3b to 130eebe Compare November 27, 2025 14:34
@alexellis
Copy link

The EasyCLA paperwork has been done for OpenFaaS Ltd now.

Slicer launches microVMs on KVM-enabled hosts with K3s and a
join token to add and remove new nodes dynamically, which are
fully isolated through Firecracker.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis
Copy link

Hi @Shubham82 @x13n it looks like GitHub picked you to take a look over our PR for Slicer. Do you have time to check it over and LTGM, etc? Or would there be someone else we'd be better pinging?

It's well tested and a fairly simple PR (from looking at past PRs to add new 'clouds').

Regards,

Alex

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025
@welteki
Copy link
Author

welteki commented Dec 5, 2025

Hi @jackfrancis, adding you here in case you have a moment to review. Please let us know if there are any changes needed to help get this PR accepted.

Regards,
Han

Add support for custom CA bundles when communicating with Slicer APIs
to enable secure connections with self-signed certificates or internal
certificate authorities.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/helm-charts cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants