Remote Git-based deploy doesn't forward CLI overrides like `--image-pull-secret` to the in-cluster `func deploy`

[lkingland]

Problem

For remote deploys that use the Git-based pipeline (a Git URL is configured), CLI flags like --image-pull-secret, --service-account, and --deployer do not reach the on-cluster func deploy step. Source is cloned from the remote Git repo on-cluster, so func.yaml in that path comes from whatever is committed in the repo — not from local disk, and not from the in-memory Function struct on the user's machine.

This is the Git-path equivalent of the bug PR #3663 fixed for the PVC-upload path. #3663 worked by persisting f to local func.yaml before invoking the pipeline, so the on-cluster step would read the updated config from the PVC. That mechanism doesn't help the Git path at all — local func.yaml is never uploaded.

Suggested approach (per @Ankitsinghsisodya)

The func-deploy task step runs func deploy inside the cluster. Forward the in-memory CLI overrides (--image-pull-secret, --service-account, --deployer, etc.) as discrete Tekton params on the pipeline run, and have the task template conditionally append them as flags to the in-cluster func deploy command.

Related

• Surfaced in discussion on Remote deploy dirties working tree by writing func.yaml before pipeline runs #3679 (which is scoped to the working-tree-dirty side-effect of fix: write func.yaml before remote deploy upload #3663 on the PVC path).
• fix: write func.yaml before remote deploy upload #3663 — original fix for the PVC-path version of this bug.

[lkingland]

cc @Ankitsinghsisodya

[vishal-iiserb]

Hey @lkingland,
I read through the issue and the discussion on #3679 and also looked at how #3663 fixed the PVC path. I understand why that fix doesn't help here — on the Git path, func.yaml comes from the remote repo, not local disk, so persisting it locally does nothing.
My understanding of the fix:
The CLI overrides like --image-pull-secret, --service-account and --deployer need to be forwarded as discrete Tekton params on the pipeline run, and the func-deploy task template should conditionally append them as flags to the on-cluster func deploy command.
My plan:

1. Forward CLI overrides as Tekton Pipeline Parameters on the pipeline run
2. Update the func-deploy task template to conditionally append those params as flags to the on-cluster func deploy command
3. Add tests to verify the flags are correctly passed through
   Could you assign this to me if my understanding is correct?

---

[Ankitsinghsisodya]

/assign