Skip to content

Conversation

@nilsocket
Copy link
Contributor

  • Convert empty interface interface{} to any wherever possible.
  • Use sliceToLookupMap() helper function with generics to remove redundant code.

@rhnvrm rhnvrm requested a review from Copilot October 30, 2025 06:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by replacing all occurrences of interface{} with the any type alias, which was introduced in Go 1.18 as a cleaner, more readable alternative. The changes are purely syntactic and maintain the same runtime behavior.

Key changes:

  • Replace interface{} with any throughout the entire codebase
  • Simplify duplicate logic in maps/maps.go by introducing a generic helper function
  • Remove extraneous blank line at end of parsers/huml/huml.go
  • Fix formatting/whitespace in several files

Reviewed Changes

Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
koanf.go Updated core type definitions and method signatures from interface{} to any
interfaces.go Updated Provider and Parser interface signatures
options.go Updated merge function signature
getters.go Updated type assertions from interface{} to any
maps/maps.go Replaced interface{} with any and refactored duplicate functions using generics
parsers/*.go Updated parser Unmarshal/Marshal signatures across all parsers
providers/*.go Updated provider Read/Watch method signatures across all providers
tests/*.go Updated test fixtures and type declarations
examples/*.go Updated callback signatures in example code
README.md Updated documentation references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhnvrm
Copy link
Collaborator

rhnvrm commented Oct 30, 2025

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants