Skip to content

Implement PR shaming system for missing metadata #38

@jerrod-storm

Description

@jerrod-storm

Context

We have shame/ labels (shame/description, shame/assignee, shame/reviewer, shame/labels) for PRs that are missing required metadata. Currently pr-hygiene just fails the check -- it doesn't apply the shame labels.

Proposal

Extend cli/pr-hygiene (or add a post-check step) to automatically apply the appropriate shame/* labels to PRs that fail hygiene checks:

  • Missing description -> shame/description
  • No assignee -> shame/assignee
  • No reviewer -> shame/reviewer
  • No labels -> shame/labels

Labels should be added via the Forgejo API. When the issue is fixed and the check re-runs, the corresponding shame label should be removed.

Notes

  • Requires a token with label-write permissions (already available as BLIZZ_PR_TOKEN)
  • Could also post a comment with a disapproving message for extra motivation
  • Consider whether the check should still hard-fail or just warn + shame

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions