refactor: better is_valid validation

Author: kawre

lua/leetcode-ui/layout/console.lua

@@ -67,8 +67,10 @@ end
 function ConsoleLayout:run(submit)
     if config.user.console.open_on_runcode then
         self:show()
-        self.result:focus()
     end
+
+    self.result:focus()
+
     Runner:init(self.question):run(submit)
 end
 

lua/leetcode-ui/popup/init.lua

@@ -31,10 +31,9 @@ function Popup:_buf_destory()
 end
 
 function Popup:focus()
-    if not vim.api.nvim_win_is_valid(self.winid) then
-        return
+    if self.winid and vim.api.nvim_win_is_valid(self.winid) then
+        vim.api.nvim_set_current_win(self.winid)
     end
-    vim.api.nvim_set_current_win(self.winid)
 end
 
 function Popup:clear() --

lua/leetcode-ui/question.lua

@@ -35,7 +35,7 @@ end
 
 ---@param code? string
 function Question:set_lines(code)
-    if not vim.api.nvim_buf_is_valid(self.bufnr) then
+    if not (self.bufnr and vim.api.nvim_buf_is_valid(self.bufnr)) then
         return
     end
 
@@ -164,7 +164,7 @@ function Question:_unmount()
         self.console:unmount()
         self.description:unmount()
 
-        if vim.api.nvim_buf_is_valid(self.bufnr) then
+        if self.bufnr and vim.api.nvim_buf_is_valid(self.bufnr) then
             vim.api.nvim_buf_delete(self.bufnr, { force = true, unload = false })
         end
 
@@ -177,7 +177,7 @@ function Question:_unmount()
 end
 
 function Question:unmount()
-    if vim.api.nvim_win_is_valid(self.winid) then
+    if self.winid and vim.api.nvim_win_is_valid(self.winid) then
         vim.api.nvim_win_close(self.winid, true)
     end
 end

lua/leetcode-ui/renderer/init.lua

@@ -24,7 +24,7 @@ function Renderer:draw(component)
     self.bufnr = component.bufnr
     self.winid = component.winid
 
-    if not vim.api.nvim_buf_is_valid(self.bufnr) then
+    if not (self.bufnr and vim.api.nvim_buf_is_valid(self.bufnr)) then
         return
     end
 

lua/leetcode-ui/renderer/menu.lua

@@ -56,7 +56,7 @@ function Menu:autocmds()
 end
 
 function Menu:cursor_move()
-    if not self.winid or not api.nvim_win_is_valid(self.winid) then
+    if not (self.winid and api.nvim_win_is_valid(self.winid)) then
         return
     end
 

lua/leetcode-ui/utils.lua

@@ -58,7 +58,7 @@ end
 
 ---@param layout lc.ui.Renderer
 function utils.win_width(layout)
-    if not vim.api.nvim_win_is_valid(layout.winid) then
+    if not (layout.winid and vim.api.nvim_win_is_valid(layout.winid)) then
         return 0
     end
     return vim.api.nvim_win_get_width(layout.winid)

lua/leetcode/command/init.lua

@@ -125,9 +125,6 @@ cmd.expire = vim.schedule_wrap(function()
     end)
 end)
 
----Merge configurations into default configurations and set it as user configurations.
----
---@param theme lc-db.Theme
 function cmd.qot()
     require("leetcode.utils").auth_guard()
 
@@ -196,7 +193,10 @@ function cmd.yank()
         return
     end
 
-    if api.nvim_buf_is_valid(q.bufnr) and api.nvim_win_is_valid(q.winid) then
+    if
+        (q.bufnr and api.nvim_buf_is_valid(q.bufnr))
+        and (q.winid and api.nvim_win_is_valid(q.winid))
+    then
         api.nvim_set_current_win(q.winid)
         api.nvim_set_current_buf(q.bufnr)
 
@@ -388,7 +388,7 @@ function cmd.inject()
         return
     end
 
-    if api.nvim_buf_is_valid(q.bufnr) then
+    if q.bufnr and api.nvim_buf_is_valid(q.bufnr) then
         local start_i, end_i = q:range(true)
         local not_found = {}
 

lua/leetcode/utils.lua

@@ -128,7 +128,9 @@ function utils.translate(content, translated_content)
 end
 
 function utils.auth_guard()
-    assert(config.auth.is_signed_in, "User not logged-in")
+    if not config.auth.is_signed_in then
+        error("User not logged-in", 0)
+    end
 end
 
 function utils.norm_ins(str)