feat: improve linux/rust librepods experience#601
Draft
debarkak wants to merge 9 commits into
Draft
Conversation
…t constraints to shrink
Addresses maintainer feedback from PR kavishdevar#586 review: - Move scrollable() into airpods_view() and nothing_view() so each view owns its own scroll behavior - Revert window.rs to call views directly without external wrapping - Fix indentation in the Nothing branch of window.rs - Views now fill available space with height(Length::Fill) and scroll internally when content exceeds viewport
debarkak
changed the title
debarkak
changed the title
… move off mode toggle to settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr focuses on improving the new linux/rust app ui, overall airpods experience, and adding some new features/functionality, mainly tested using airpods 4 anc on fedora linux 44 kde (amd64).
a lot of this is based on issues/limitations i noticed while daily driving librepods for a while now, along with some followup improvements related to the new linux app rewrite (#241) and my previous scrollable ui fix pr (#586).
currently some parts of the ui still feel a bit cramped/incomplete compared to the experience on apple devices, especially stuff like battery indicators, disconnected states, listening mode controls, and visibility of sensitive information.
also noticed some weird behavior/issues while using the app daily, mainly around ear detection/playback handling and media controls on my setup, so this pr will also include fixes/improvements related to that wherever possible.
planned improvements/features for this pr:
will probably add more smaller improvements/features/fixes while working on this/testing.
might also work on some of the remaining incomplete/unimplemented things mentioned in #241 where possible.