Skip to content

fix: add scrollable wrapper to device views #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
debarkak wants to merge 3 commits into
base: linux/rust
Choose a base branch
from
Open

fix: add scrollable wrapper to device views #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
798498b
refactor: wrap device views in scrollable containers and update heigh…
debarkak May 7, 2026
0838408
refactor: move scrollable wrapping into view functions
debarkak May 12, 2026
8c6bb40
Merge branch 'kavishdevar:linux/rust' into linux/rust
debarkak May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions linux-rust/src/ui/airpods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use iced::overlay::menu;
use iced::widget::button::Style;
use iced::widget::rule::FillMode;
use iced::widget::{
Space, button, column, combo_box, container, row, rule, text, text_input, toggler,
Space, button, column, combo_box, container, row, rule, scrollable, text, text_input, toggler,
};
use iced::{Background, Border, Center, Color, Length, Padding, Theme};
use log::error;
Expand Down Expand Up @@ -507,7 +507,7 @@ pub fn airpods_view<'a>(
}
}

container(column![
let content = container(column![
rename_input,
Space::new().height(Length::from(20)),
listening_mode,
Expand All @@ -519,8 +519,10 @@ pub fn airpods_view<'a>(
information_col
])
.padding(20)
.center_x(Length::Fill)
.height(Length::Fill)
.center_x(Length::Fill);

container(scrollable(content).height(Length::Fill))
.height(Length::Fill)
}

fn run_async_in_thread<F>(fut: F)
Expand Down
10 changes: 6 additions & 4 deletions linux-rust/src/ui/nothing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use iced::border::Radius;
use iced::overlay::menu;
use iced::widget::combo_box;
use iced::widget::text_input;
use iced::widget::{Space, column, container, row, text};
use iced::widget::{Space, column, container, row, scrollable, text};
use iced::{Background, Border, Length, Theme};
use std::collections::HashMap;
use std::sync::Arc;
Expand Down Expand Up @@ -158,7 +158,7 @@ pub fn nothing_view<'a>(
style
});

container(column![
let content = container(column![
noise_control_mode,
Space::new().height(Length::from(20)),
container(information_col)
Expand All @@ -174,8 +174,10 @@ pub fn nothing_view<'a>(
.padding(20)
])
.padding(20)
.center_x(Length::Fill)
.height(Length::Fill)
.center_x(Length::Fill);

container(scrollable(content).height(Length::Fill))
.height(Length::Fill)
}

fn run_async_in_thread<F>(fut: F)
Expand Down
2 changes: 1 addition & 1 deletion linux-rust/src/ui/window.rs
View file
Open in desktop
Comment thread
debarkak marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ impl App {
id,
&devices_list,
state,
aacp_manager.clone()
aacp_manager.clone(),
))
})
}
Expand Down