Define DefaultHelmJobImage in K3s, overriding what helm-controller defaults to. (#13258)

Signed-off-by: Derek Nola <derek.nola@suse.com>

Author: dereknola

pkg/server/server.go

@@ -40,6 +40,8 @@ import (
 	clientset "k8s.io/client-go/kubernetes"
 )
 
+var DefaultHelmJobImage = "rancher/klipper-helm:v0.9.10-build20251111"
+
 func ResolveDataDir(dataDir string) (string, error) {
 	dataDir, err := datadir.Resolve(dataDir)
 	return filepath.Join(dataDir, "server"), err
@@ -217,11 +219,12 @@ func coreControllers(ctx context.Context, sc *Context, config *Config) error {
 		return err
 	}
 
-	// apply SystemDefaultRegistry setting to Helm before starting controllers
+	// Apply SystemDefaultRegistry setting to Helm before starting controllers.
+	// Additionally, set the helm job image to the immutable default image, internally helm-controller default to latest.
 	if config.ControlConfig.HelmJobImage != "" {
 		helmchart.DefaultJobImage = config.ControlConfig.HelmJobImage
 	} else if config.ControlConfig.SystemDefaultRegistry != "" {
-		helmchart.DefaultJobImage = config.ControlConfig.SystemDefaultRegistry + "/" + helmchart.DefaultJobImage
+		helmchart.DefaultJobImage = config.ControlConfig.SystemDefaultRegistry + "/" + DefaultHelmJobImage
 	}
 
 	if sc.Helm != nil {