Skip to content

Commit d218031

Browse files
author
Martin Hering
committed
remove option for fixed item padding, fixed left margin
1 parent 22ae490 commit d218031

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

JNWCollectionView/JNWCollectionViewGridLayout.h

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,6 @@ extern NSString * const JNWCollectionViewGridLayoutFooterKind;
6262
/// override any value set here.
6363
@property (nonatomic, assign) CGSize itemSize;
6464

65-
/// Choose whether even padding between horizontal items is enabled.
66-
///
67-
/// Default is YES.
68-
@property (nonatomic, assign) BOOL itemPaddingEnabled;
69-
7065
/// The vertical spacing between rows in the grid.
7166
///
7267
/// Defaults to 0.
@@ -78,3 +73,12 @@ extern NSString * const JNWCollectionViewGridLayoutFooterKind;
7873
@property (nonatomic, assign) CGFloat itemHorizontalMargin;
7974

8075
@end
76+
77+
78+
@interface JNWCollectionViewGridLayout (Deprecated)
79+
/// Choose whether even padding between horizontal items is enabled.
80+
/// Not used anymore. Please use Flow Layout.
81+
///
82+
/// Default is YES.
83+
@property (nonatomic, assign) BOOL itemPaddingEnabled;
84+
@end

JNWCollectionView/JNWCollectionViewGridLayout.m

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ - (instancetype)init {
7272
self = [super init];
7373
if (self == nil) return nil;
7474
self.itemSize = JNWCollectionViewGridLayoutDefaultSize;
75-
self.itemPaddingEnabled = YES;
76-
;
7775
return self;
7876
}
7977

@@ -117,12 +115,8 @@ - (void)prepareLayout {
117115

118116
CGFloat itemPadding = 0;
119117
if (numberOfColumns > 0) {
120-
if (self.itemHorizontalMargin == 0 && self.itemPaddingEnabled) {
121-
CGFloat totalPadding = totalWidth - (numberOfColumns * itemSize.width);
122-
itemPadding = floorf(totalPadding / numberOfColumns);
123-
} else {
124-
itemPadding = self.itemHorizontalMargin;
125-
}
118+
CGFloat totalPadding = totalWidth - (numberOfColumns * itemSize.width);
119+
itemPadding = floorf(totalPadding / numberOfColumns);
126120
}
127121
else {
128122
numberOfColumns = 1;
@@ -147,7 +141,7 @@ - (void)prepareLayout {
147141
for (NSInteger item = 0; item < numberOfItems; item++) {
148142
CGPoint origin = CGPointZero;
149143
NSInteger column = ((item - (item % numberOfColumns)) / numberOfColumns);
150-
origin.x = sectionInsets.left + itemPadding/2 + totalWidth/numberOfColumns * (item % numberOfColumns);
144+
origin.x = sectionInsets.left + self.itemHorizontalMargin/2 + itemPadding/2 + totalWidth/numberOfColumns * (item % numberOfColumns);
151145
origin.y = column * itemSize.height + column * verticalSpacing;
152146
sectionInfo.itemInfo[item].origin = origin;
153147
}

demo/JNWCollectionViewDemo/GridDemoViewController.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ - (void)awakeFromNib {
2828
JNWCollectionViewGridLayout *gridLayout = [[JNWCollectionViewGridLayout alloc] init];
2929
gridLayout.delegate = self;
3030
gridLayout.verticalSpacing = 10.f;
31+
gridLayout.itemHorizontalMargin = 10.f;
3132

3233
self.collectionView.collectionViewLayout = gridLayout;
3334
self.collectionView.dataSource = self;

0 commit comments

Comments
 (0)