improve tests robustness

Author: evakhoni

packages/jumpstarter-driver-qemu/jumpstarter_driver_qemu/driver.py

@@ -21,7 +21,7 @@
 from jumpstarter_driver_opendal.driver import FlasherInterface
 from jumpstarter_driver_power.driver import PowerInterface, PowerReading
 from jumpstarter_driver_pyserial.driver import PySerial
-from pydantic import BaseModel, ByteSize, Field, TypeAdapter, validate_call
+from pydantic import BaseModel, ByteSize, Field, TypeAdapter, ValidationError, validate_call
 from qemu.qmp import QMPClient
 from qemu.qmp.protocol import ConnectError, Runstate
 
@@ -411,7 +411,7 @@ def _validate_size(self, size: str) -> None:
         try:
             s = size
             TypeAdapter(ByteSize).validate_python(s + "iB" if s[-1] in "kmgtKMGT" else s)
-        except Exception:
+        except (ValidationError, IndexError):
             raise ValueError(f"Invalid size: '{size}'. Use e.g. '20G', '512M', '2T'") from None
 
     @export

packages/jumpstarter-driver-qemu/jumpstarter_driver_qemu/driver_test.py

@@ -162,16 +162,16 @@ async def test_resize_succeeds(resize_test):
 
     with patch("jumpstarter_driver_qemu.driver.run_process", side_effect=_mock_qemu_img_info(current)) as mock_run:
         with patch("jumpstarter_driver_qemu.driver.shutil.disk_usage", return_value=mock_usage):
-            with patch("jumpstarter_driver_qemu.driver.Popen"):
-                try:
+            # Mock Popen to stop before actually starting QEMU VM
+            with patch("jumpstarter_driver_qemu.driver.Popen", side_effect=RuntimeError("mock popen")):
+                with pytest.raises(RuntimeError, match="mock popen"):
                     await driver.children["power"].on()
-                except Exception:
-                    pass  # Expected to fail at Popen
 
-    # Find the resize call
-    resize_calls = [c for c in mock_run.call_args_list if "resize" in c[0][0]]
+    # Find the resize call and verify size argument
+    resize_calls = [c for c in mock_run.call_args_list if "resize" in c.args[0]]
     assert resize_calls, "qemu-img resize should be called"
-    assert resize_calls[0][0][0][-1] == str(20 * 1024**3)
+    resize_cmd = resize_calls[0].args[0]  # ['qemu-img', 'resize', path, size]
+    assert resize_cmd[-1] == str(20 * 1024**3)
 
 
 def test_set_disk_size_valid():