-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Description
In the readme file, it says that width and height use the parent values if these options are not set. Implying that the options should have higher priority.
But the actual way it behaves is that the parent value has higher priority, and these values are only used if the parent container is too small.
Maybe should be something like this?
if(noparent)
{
width = settings.width || $elm.parent().width();
height = settings.height || $elm.parent().height();
}
else
{
$elm.append(canvas);
width = settings.width || $elm.innerWidth();
height = settings.height || $elm.innerHeight();
}
The width/height < 2 check becomes redundant if this logic is used.
Not sure if this will break existing integrations, so it might need to be a new option. Or just reflect the actual behaviour in the instructions.
Thanks
Metadata
Metadata
Assignees
Labels
No labels