-
Notifications
You must be signed in to change notification settings - Fork 105
Open
Description
Is your feature request related to a problem? Please describe.
Currently, the code marks the username as a secret using core.setSecret(username) in setOidcStepOutputs (src/oidc-utils.ts). Usernames are generally not sensitive information, and marking them as secrets can result in unnecessary log obfuscation and confusion. User name can be used as part of many other not sensitive names used in the workflow.
Describe the solution you'd like to see
Remove the call to core.setSecret(username) from the setOidcStepOutputs function and only mark truly sensitive values such as tokens and passwords as secrets. If the username is ever sensitive, ensure that is a documented exception.
Describe alternatives you've considered
- Leaving the code as-is, which may lead to unnecessary log redactions for non-sensitive values.
- Adding a comment to clarify when a username should be treated as a secret (if ever).
Additional context
Reference:
setup-jfrog-cli/src/oidc-utils.ts
Line 160 in 29fa519
| core.setSecret(username); |
njmccorkle, kamilk, jsliwinski-r1, ajschmidt8 and stjen
Metadata
Metadata
Assignees
Labels
No labels