Commit 7e6e7a2
Slack: Remove extra a11y attributes from
Based on the `close_flexpane` button markup on Slack now, we have:
`<button class="btn_basic close_flexpane" aria-label="Close Right Sidebar" title="Close Right Sidebar" type="button">`
- Since this element is a `<button>`, the `role` attribute is no longer necessary
- Since this element has an `aria-label` attribute, we no longer need to add one
- Update "Slack Accessibility Fixes" in README to reflect the above changesclose_flexpane button (#11)1 parent c011ddf commit 7e6e7a2
2 files changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 22 | | |
29 | 23 | | |
30 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
| |||
0 commit comments