|
| 1 | +package effectivejava.chapter11.item79; |
| 2 | +import java.util.*; |
| 3 | +import java.util.concurrent.CopyOnWriteArrayList; |
| 4 | + |
| 5 | +// Broken - invokes alien method from synchronized block! |
| 6 | +public class ObservableSet<E> extends ForwardingSet<E> { |
| 7 | + public ObservableSet(Set<E> set) { super(set); } |
| 8 | + |
| 9 | +// private final List<SetObserver<E>> observers |
| 10 | +// = new ArrayList<>(); |
| 11 | + |
| 12 | +// public void addObserver(SetObserver<E> observer) { |
| 13 | +// synchronized(observers) { |
| 14 | +// observers.add(observer); |
| 15 | +// } |
| 16 | +// } |
| 17 | +// |
| 18 | +// public boolean removeObserver(SetObserver<E> observer) { |
| 19 | +// synchronized(observers) { |
| 20 | +// return observers.remove(observer); |
| 21 | +// } |
| 22 | +// } |
| 23 | + |
| 24 | +// private void notifyElementAdded(E element) { |
| 25 | +// synchronized(observers) { |
| 26 | +// for (SetObserver<E> observer : observers) |
| 27 | +// observer.added(this, element); |
| 28 | +// } |
| 29 | +// } |
| 30 | + |
| 31 | +// // Alien method moved outside of synchronized block - open calls |
| 32 | +// private void notifyElementAdded(E element) { |
| 33 | +// List<SetObserver<E>> snapshot = null; |
| 34 | +// synchronized(observers) { |
| 35 | +// snapshot = new ArrayList<>(observers); |
| 36 | +// } |
| 37 | +// for (SetObserver<E> observer : snapshot) |
| 38 | +// observer.added(this, element); |
| 39 | +// } |
| 40 | + |
| 41 | + // Thread-safe observable set with CopyOnWriteArrayList |
| 42 | + private final List<SetObserver<E>> observers = |
| 43 | + new CopyOnWriteArrayList<>(); |
| 44 | + |
| 45 | + public void addObserver(SetObserver<E> observer) { |
| 46 | + observers.add(observer); |
| 47 | + } |
| 48 | + |
| 49 | + public boolean removeObserver(SetObserver<E> observer) { |
| 50 | + return observers.remove(observer); |
| 51 | + } |
| 52 | + |
| 53 | + private void notifyElementAdded(E element) { |
| 54 | + for (SetObserver<E> observer : observers) |
| 55 | + observer.added(this, element); |
| 56 | + } |
| 57 | + |
| 58 | + @Override public boolean add(E element) { |
| 59 | + boolean added = super.add(element); |
| 60 | + if (added) |
| 61 | + notifyElementAdded(element); |
| 62 | + return added; |
| 63 | + } |
| 64 | + |
| 65 | + @Override public boolean addAll(Collection<? extends E> c) { |
| 66 | + boolean result = false; |
| 67 | + for (E element : c) |
| 68 | + result |= add(element); // Calls notifyElementAdded |
| 69 | + return result; |
| 70 | + } |
| 71 | +} |
0 commit comments