Skip to content

Commit 28a5f4d

Browse files
committed
small refactor
1 parent 3134c54 commit 28a5f4d

File tree

2 files changed

+10
-25
lines changed
  • src

2 files changed

+10
-25
lines changed

src/main/java/com/capgemini/training/appointmentbooking/dataaccess/entity/BaseEntity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public class BaseEntity {
1717

1818
@Version
1919
private int version;
20-
20+
21+
@Column(insertable = true, updatable = false)
2122
private Date created;
2223

2324
@Column(name="LAST_UPDATED")

src/test/java/com/capgemini/training/appointmentbooking/dataaccess/entity/EntitySmokeTest.java

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,34 +22,18 @@ public class EntitySmokeTest {
2222
void loadAllClasses() {
2323

2424
// given
25-
Map<EntityName, Integer> classMap = Map.ofEntries( //
26-
Map.entry(EntityName.USER, 8), //
27-
Map.entry(EntityName.CLIENT, 4), //
28-
Map.entry(EntityName.SPECIALIST, 4), //
29-
Map.entry(EntityName.TREATMENT, 12), //
30-
Map.entry(EntityName.APPOINTMENT, 20)
25+
Map<Class<? extends BaseEntity>, Integer> classMap = Map.of( //
26+
UserEntity.class, 8, //
27+
ClientEntity.class, 4, //
28+
SpecialistEntity.class, 4, //
29+
TreatmentEntity.class, 12, //
30+
AppointmentEntity.class, 20
3131
);
3232

3333
// when //then
34-
classMap.entrySet().stream() //
35-
.forEach(entry -> {
36-
List<?> result = em.createQuery("from " + entry.getKey().simpleName).getResultList();
37-
assertThat(result).hasSize(entry.getValue());
38-
});
39-
34+
classMap.forEach((entityType, expectedCount) ->
35+
assertThat(em.createQuery("from " + entityType.getSimpleName()).getResultList()).hasSize(expectedCount));
4036
}
4137

42-
enum EntityName {
43-
44-
APPOINTMENT("AppointmentEntity"), CLIENT("ClientEntity"), SPECIALIST("SpecialistEntity"),
45-
TREATMENT("TreatmentEntity"), USER("UserEntity");
46-
47-
private String simpleName;
48-
49-
private EntityName(String simpleName) {
50-
this.simpleName = simpleName;
51-
}
52-
53-
}
5438

5539
}

0 commit comments

Comments
 (0)