[Bug] Error message in console due to rewritten language selection

[ann0see]

URL
https://jamulus.io

Describe the bug

jamuluswebsite/_includes/footer.html

Lines 27 to 41 in 2c40eec

	<script>
	var ja = window.navigator.language || window.navigator.userLanguage;
	var mu = document.documentElement.lang;
	var lus = [{% for lng in site.languages %}"{{ lng }}",{% endfor %}];
	var regex = RegExp('^' + mu);
	if (!regex.test(ja)) { // the language the browser has sent is not the language of the document
	// check if we support the language of the browser
	lus.forEach(function (lng, i) {
	if (ja.match('^' + lng)) { // this language is supported. We could add a suggestion here
	document.getElementById('langselect').classList.add('chlang','red');
	document.getElementById('suglang').style.display = "block";
	document.querySelectorAll('[data-slang='+ lng +']')[0].classList.add("proplang");
	}
	});
	}

does not find suglang as the respective code has been removed (if we use the "new" language selector)

We should have a way to still mark suggested languages somehow.

@ignotus666

[ignotus666]

@ann0see
Ok, I'll look into it. Should it display a message (to the left of the langselect dropdown maybe)?

[ann0see]

Best case would be a thing which can be clicked that sets the correct language

[ignotus666]

I think I recall that language suggestion message as being very annoying visually, which is why I proposed removing it here - and as no one was opposed, that's what I did, replacing it with auto-detection of browser language, which was later rejected. If we do bring back the message, it should be possible to dismiss it, or if clicked on, the preference is saved for future visits (instead of having to click on it every time) but this entails saving data to the user's PC and I'm not sure we want that.

[ann0see]

but this entails saving data to the user's PC and I'm not sure we want that.

I think if we use something like local storage it is acceptable - as long as it can't be used for tracking.

[ann0see]

The user should have an easy way to select the detected language but not be forced to use this language.

[ignotus666]

Ok cool, I'll see what I can do.

[ignotus666]

Here's a suggestion:

It just stores a langSuggestionHandled flag. Clicking on either button makes the message go away.

[ignotus666]

This would need translating, mind - the message is in /wiki/en/misc/general.yml.

[pljones]

but this entails saving data to the user's PC and I'm not sure we want that.

I think if we use something like local storage it is acceptable - as long as it can't be used for tracking.

A simple permanent cookie is better than local storage. More people will have local storage disabled, who're worried about such things. (Cookies are more compatible, too.)

[ann0see]

Local storage is more modern and easier to handle. But it doesn't matter - as long as we clearly state it in the privacy policy

[ignotus666]

Ok, well, I'll use whatever you guys agree is best. Any thoughts about the styling, colours, wording, position, etc? E.g. I think "Apply" would be better than "Activate", and maybe just a button with an "X" instead of dismiss, to keep it short.