does not work well with forks

[lifeofguenter]

I am trying to use this with the following setup:

• teamOwner/repository-foobar
• user/repository-foobar (fork of teamOwner/repository-foobar)
• PR is created from a branch on user against teamOwner/repository-foobar

This does work with the "cron bitbucket jenkins plugin". However with bbprb, it only works if I set the repository url within jenkins to the following:

git@bitbucket.org:${bbprbSourceRepository}.git

however, internally the plugin will still try to use dest* for the build-status, which will not work because the dest does not have the commit-hash of the src.

E.g. builds work, but build-status api does not work.

[ip1981]

Interesting. Could you post contents of webhook payload?

[lifeofguenter]

{
  "pullrequest": {
    "type": "pullrequest",
    "description": "",
    "links": {
      "decline": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/decline"
      },
      "commits": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/commits"
      },
      "self": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1"
      },
      "comments": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/comments"
      },
      "merge": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/merge"
      },
      "html": {
        "href": "https://bitbucket.org/teamAccount/docker-library-glassfish/pull-requests/1"
      },
      "activity": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/activity"
      },
      "diff": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/diff"
      },
      "approve": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/approve"
      },
      "statuses": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/pullrequests/1/statuses"
      }
    },
    "title": "init implementation",
    "close_source_branch": false,
    "reviewers": [],
    "id": 1,
    "destination": {
      "commit": {
        "hash": "9ff286f1866f",
        "links": {
          "self": {
            "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish/commit/9ff286f1866f"
          }
        }
      },
      "branch": {
        "name": "master"
      },
      "repository": {
        "full_name": "teamAccount/docker-library-glassfish",
        "type": "repository",
        "name": "docker-library-glassfish",
        "links": {
          "self": {
            "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish"
          },
          "html": {
            "href": "https://bitbucket.org/teamAccount/docker-library-glassfish"
          },
          "avatar": {
            "href": "https://bitbucket.org/teamAccount/docker-library-glassfish/avatar/32/"
          }
        },
        "uuid": "{3cf80a08-4c27-4b03-8c10-9830f9b82c4f}"
      }
    },
    "comment_count": 0,
    "summary": {
      "raw": "",
      "markup": "markdown",
      "html": ""
    },
    "source": {
      "commit": {
        "hash": "5cf62cffa94e",
        "links": {
          "self": {
            "href": "https://api.bitbucket.org/2.0/repositories/lifeofguenter/docker-library-glassfish/commit/5cf62cffa94e"
          }
        }
      },
      "branch": {
        "name": "init"
      },
      "repository": {
        "full_name": "lifeofguenter/docker-library-glassfish",
        "type": "repository",
        "name": "docker-library-glassfish",
        "links": {
          "self": {
            "href": "https://api.bitbucket.org/2.0/repositories/lifeofguenter/docker-library-glassfish"
          },
          "html": {
            "href": "https://bitbucket.org/lifeofguenter/docker-library-glassfish"
          },
          "avatar": {
            "href": "https://bitbucket.org/lifeofguenter/docker-library-glassfish/avatar/32/"
          }
        },
        "uuid": "{f71ecff3-f798-4eb0-a2c4-e2cc10e32233}"
      }
    },
    "state": "OPEN",
    "author": {
      "username": "lifeofguenter",
      "type": "user",
      "display_name": "Gunter Grodotzki",
      "uuid": "{3b259af4-7962-4000-8a19-fd71984e315f}",
      "links": {
        "self": {
          "href": "https://api.bitbucket.org/2.0/users/lifeofguenter"
        },
        "html": {
          "href": "https://bitbucket.org/lifeofguenter/"
        },
        "avatar": {
          "href": "https://bitbucket.org/account/lifeofguenter/avatar/32/"
        }
      }
    },
    "created_on": "2018-02-19T08:59:54.889342+00:00",
    "participants": [],
    "reason": "",
    "updated_on": "2018-02-19T09:02:44.731139+00:00",
    "merge_commit": null,
    "closed_by": null,
    "task_count": 0
  },
  "actor": {
    "username": "lifeofguenter",
    "type": "user",
    "display_name": "Gunter Grodotzki",
    "uuid": "{3b259af4-7962-4000-8a19-fd71984e315f}",
    "links": {
      "self": {
        "href": "https://api.bitbucket.org/2.0/users/lifeofguenter"
      },
      "html": {
        "href": "https://bitbucket.org/lifeofguenter/"
      },
      "avatar": {
        "href": "https://bitbucket.org/account/lifeofguenter/avatar/32/"
      }
    }
  },
  "repository": {
    "scm": "git",
    "website": "",
    "name": "docker-library-glassfish",
    "links": {
      "self": {
        "href": "https://api.bitbucket.org/2.0/repositories/teamAccount/docker-library-glassfish"
      },
      "html": {
        "href": "https://bitbucket.org/teamAccount/docker-library-glassfish"
      },
      "avatar": {
        "href": "https://bitbucket.org/teamAccount/docker-library-glassfish/avatar/32/"
      }
    },
    "project": {
      "links": {
        "self": {
          "href": "https://api.bitbucket.org/2.0/teams/teamAccount/projects/DOG"
        },
        "html": {
          "href": "https://bitbucket.org/account/user/teamAccount/projects/DOG"
        },
        "avatar": {
          "href": "https://bitbucket.org/account/user/teamAccount/projects/DOG/avatar/32"
        }
      },
      "type": "project",
      "uuid": "{264c4d39-d619-446c-8477-60a4abcdc05e}",
      "key": "DOG",
      "name": "DockerLibrary"
    },
    "full_name": "teamAccount/docker-library-glassfish",
    "owner": {
      "username": "teamAccount",
      "type": "team",
      "display_name": "teamAccount",
      "uuid": "{efb6f174-9ca7-4885-adfa-12e693006667}",
      "links": {
        "self": {
          "href": "https://api.bitbucket.org/2.0/teams/teamAccount"
        },
        "html": {
          "href": "https://bitbucket.org/teamAccount/"
        },
        "avatar": {
          "href": "https://bitbucket.org/account/teamAccount/avatar/32/"
        }
      }
    },
    "type": "repository",
    "is_private": true,
    "uuid": "{3cf80a08-4c27-4b03-8c10-9830f9b82c4f}"
  }
}

thanks for having a look! eg. I think the gist is, that you might have to check if sourceRepo differs from destRepo?

[ip1981]

May be related to https://bitbucket.org/site/master/issues/13162/pipelines-for-pull-requests-from-forks

I remember, at Github a PR is a branch of destination project, that is, you can clone destination repository and checkout the PR.

[ip1981]

We probably can use git@bitbucket.org:${bbprbSourceRepository}.git for a workaround, but I personally want to merge before building, i. e. I'd need two repositories.

[lifeofguenter]

these is the implementation on the other bitbucket plugin:

• https://github.com/nishio-dens/bitbucket-pullrequest-builder-plugin/blob/5b86923fba465f914ed0f9da6393b9ae9e22287d/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketRepository.java#L140
• https://github.com/nishio-dens/bitbucket-pullrequest-builder-plugin/blob/92cf04a50b051cb6c96d0000eb8763797b239496/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/bitbucket/ApiClient.java#L149

e.g. they hardcode to use the sourceRepo + sourceCommit to set the build-status, which seems to be the correcter way to do things.

Even if the PR is not from a fork, using sourceRepo + sourceCommit would still be correct.

I don't think merging before building should be necessary. Using git@bitbucket.org:${bbprbSourceRepository}.git itself as repo-url in the jekins-git plugin I think works well - maybe it can be overwritten with the actual sourceRepo in the future?

[ip1981]

It looks broken by design :)

I am gonna explore more options.

Ref. https://community.atlassian.com/t5/Bitbucket-questions/Creating-a-build-against-a-pull-request/qaq-p/76594

[lifeofguenter]

there are quite some open tickets making bitbucket more difficult to use in CI/CD, especially forking and pull-requesting:

• https://bitbucket.org/site/master/issues/5814/refify-pull-requests-by-making-them-a-ref
• https://bitbucket.org/site/master/issues/4056/admin-access-to-the-fork-repo-bb-4257
• https://bitbucket.org/site/master/issues/15573/private-forks-should-inherit-acl
• https://bitbucket.org/site/master/issues/15576/when-squash-merging-a-pr-the-diff-will-not

However, it still works relatively well and without merging before build - I think its just that the current URL for the build-status is generated wrong, as it is generated towards destination* when it should be generated towards source* - then everything should be working as expected with any situation (forking and non-forking PR)

[ip1981]

I think I get your point, there is no problem in changing to the source repository. I just think I need something better :)

Meanwhile, could you try b64dfe3 ?

[ip1981]

UP!