[enhancement]: Clip Skip for SDXL in the generation tab

[SaraDonzellini]

Is there an existing issue for this?

• I have searched the existing issues

Contact Details

No response

What should this feature add?

In the generation tab, when selecting SD1 models, there is the possibility to add CLIP Skip.
I'd like the same option for SDXL models.
Would be wonderful to have two sliders for CLIP 1 and 2.

Alternatives

No response

Additional Content

No response

[joshistoast]

This subject has been heavily debated in the past when sdxl was first implemented and, the developer consensus became that clip skip is not needed in invoke for sdxl.

Initially I wasn't happy with this decision, and conducted some tests in the workflows tab (add a clip skip node to each sdxl clip) and discovered that invoke's sdxl implementation works better without it.

I encourage you to run some tests in the workflows tab and if you can find some areas in which an sdxl clip skip produces better results, maybe then we can revisit this discussion. But until then this is not planned.

[DustyShoe]

I also ran multiple tests with CLIP Skip in the workflow editor. Have to admit, it did not provide any real benefits to image quality.
The images produced are indeed different, but not once were they better in quality.

For clarity, Invoke already applies last-layer skip by default. Here’s a really in-depth explanation of this part:
https://discord.com/channels/1020123559063990373/1020123559831539744/1414717192402108548
by @dunkeroni

I agree with Josh and would like to see examples of this feature being useful or making a significant improvement in image generation.

[SaraDonzellini]

I encourage you to run some tests in the workflows tab and if you can find some areas in which an sdxl clip skip produces better results, maybe then we can revisit this discussion. But until then this is not planned.

I also ran multiple tests with CLIP Skip in the workflow editor. Have to admit, it did not provide any real benefits to image quality.
The images produced are indeed different, but not once were they better in quality.

I did, and I was asking because I use clip skip in workflows, with a few models it makes a big difference, maybe not in quality but in style. For example, the model Event Horizon Picto XL (v1.5) it's too realistic with clip at 0; with both clips skipped at 2 (which is what is recommended to use), it becomes more painterly.

Scratch all of the above, it was an "old" test (a couple of months ago) and apparently v2.0 does not do that anymore.
(。_。)

Maybe it was just pure coincidence and my brain imploded; it could very well be (I did use the same seed to test it though, ㄟ( ▔, ▔ )ㄏ).

I tried more models that recommend clip skip and in fact it was kind of better without; the style changes a bit (from realism to more painterly) but nothing that can't be fixed by prompting it better.

For clarity, Invoke already applies last-layer skip by default. Here’s a really in-depth explanation of this part:
https://discord.com/channels/1020123559063990373/1020123559831539744/1414717192402108548

Thanks by the way, I did not know that!

I kind if have a question though, why some models recommend a n clip skip then? I'm confused.

Thanks for the clarifications anyway! Always happy to learn new things.