Extract update sync status (#196)

* Create napi safe wrap

* Extract create folder placeholder

* Extract create file placeholder

* Extract get file identity

* Update package.json

* Extract connect sync root

* Extract hydrate file

* Hydrate file thread safe

* Improve safe wrap

* Remove delete file from c++

* Extract convert to placeholder

* Refactor register sync root

* Extract code

* Improve

* Simplify providerId

* Commit

* Commit

* Commit

* Update get_registered_sync_roots.cpp

* Update addon.node

* Commt

* Commit

* Simplify unregister

* Fix wrapper

* Remove context

* Improve napi

* Template napi_extract_args

* Extract dehydrate file wrapper

* Refactor dehydrate file

* Throw exceptions

* Commit

* Extract disconnect sync root

* Extract get placeholder state

* Remove sync state

* Extract update sync status

* Update publish-npm.yml

* Update addon.node

* Clean

* Update addon.node

Author: dajimenezriv-internxt

.github/workflows/publish-npm.yml

@@ -9,11 +9,6 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 1
 
-    permissions:
-      contents: read
-      id-token: write
-      packages: write
-
     steps:
       - name: Checkout code
         uses: actions/checkout@v4

binding.gyp

@@ -40,7 +40,8 @@
         "native-src/virtual_drive/hydrate_file.cpp",
         "native-src/virtual_drive/register_sync_root/register_sync_root.cpp",
         "native-src/virtual_drive/register_sync_root/register_sync_root_wrapper.cpp",
-        "native-src/virtual_drive/unregister_sync_root_wrapper.cpp"
+        "native-src/virtual_drive/unregister_sync_root_wrapper.cpp",
+        "native-src/virtual_drive/update_sync_status/update_sync_status_wrapper.cpp"
       ],
       "include_dirs": [
         "include",
@@ -52,7 +53,8 @@
         "include/virtual_drive",
         "include/virtual_drive/get_placeholder_state",
         "include/virtual_drive/get_registered_sync_roots",
-        "include/virtual_drive/register_sync_root"
+        "include/virtual_drive/register_sync_root",
+        "include/virtual_drive/update_sync_status"
       ],
       "libraries": [
         "-lCldApi.lib",

dist/addon.node

@@ -59,5 +59,4 @@ class FileHandle
 
 FileHandle handleForPath(const std::wstring &path);
 
-std::string pinStateToString(PinState state);
 CF_PIN_STATE pinStateToCfPinState(PinState state);

include/placeholders_interface/PlaceHolderInfo.h

@@ -0,0 +1,5 @@
+#pragma once
+
+#include <node_api.h>
+
+napi_value update_sync_status_wrapper(napi_env info, napi_callback_info args);

include/virtual_drive/update_sync_status/update_sync_status_wrapper.h

@@ -44,25 +44,6 @@ CF_PIN_STATE pinStateToCfPinState(PinState state)
     }
 }
 
-std::string pinStateToString(PinState state)
-{
-    switch (state)
-    {
-    case PinState::Inherited:
-        return "Inherited";
-    case PinState::AlwaysLocal:
-        return "AlwaysLocal";
-    case PinState::OnlineOnly:
-        return "OnlineOnly";
-    case PinState::Unspecified:
-        return "Unspecified";
-    case PinState::Excluded:
-        return "Excluded";
-    default:
-        return "Unknown";
-    }
-}
-
 PlaceHolderInfo::PlaceHolderInfo()
     : _data(nullptr, [](CF_PLACEHOLDER_BASIC_INFO *) {})
 {

native-src/placeholders_interface/PlaceHolderInfo.cpp

@@ -270,32 +270,6 @@ PlaceholderResult Placeholders::ConvertToPlaceholder(const std::wstring &fullPat
     return result;
 }
 
-std::wstring GetErrorMessageFromHRESULT(HRESULT hr)
-{
-    LPWSTR errorMessage = nullptr;
-    DWORD result = FormatMessageW(
-        FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
-        nullptr,
-        hr,
-        MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
-        reinterpret_cast<LPWSTR>(&errorMessage),
-        0,
-        nullptr);
-
-    std::wstring message;
-    if (result > 0 && errorMessage)
-    {
-        message = errorMessage;
-        LocalFree(errorMessage);
-    }
-    else
-    {
-        message = L"Error desconocido";
-    }
-
-    return message;
-}
-
 /**
  * @brief Mark a file or directory as synchronized
  * @param filePath path to the file or directory

native-src/placeholders_interface/Planceholders.cpp

@@ -20,6 +20,7 @@
 #include "dehydrate_file.h"
 #include "disconnect_sync_root.h"
 #include "get_placeholder_state_wrapper.h"
+#include "update_sync_status_wrapper.h"
 #include "NAPI_SAFE_WRAP.h"
 
 napi_value CreatePlaceholderFile(napi_env env, napi_callback_info args) {
@@ -94,35 +95,8 @@ napi_value addLoggerPathWrapper(napi_env env, napi_callback_info args)
     return result;
 }
 
-napi_value UpdateSyncStatusWrapper(napi_env env, napi_callback_info args)
-{
-    size_t argc = 3;
-    napi_value argv[3];
-
-    napi_get_cb_info(env, args, &argc, argv, nullptr, nullptr);
-    if (argc < 3)
-    {
-        napi_throw_error(env, nullptr, "Three arguments are required for UpdateSyncStatus");
-        return nullptr;
-    }
-
-    size_t pathLength;
-    napi_get_value_string_utf16(env, argv[0], nullptr, 0, &pathLength);
-
-    std::unique_ptr<wchar_t[]> widePath(new wchar_t[pathLength + 1]);
-    napi_get_value_string_utf16(env, argv[0], reinterpret_cast<char16_t *>(widePath.get()), pathLength + 1, nullptr);
-
-    bool inputSyncState;
-    napi_get_value_bool(env, argv[1], &inputSyncState);
-
-    bool isDirectory;
-    napi_get_value_bool(env, argv[2], &isDirectory);
-
-    Placeholders::UpdateSyncStatus(widePath.get(), inputSyncState, isDirectory);
-
-    napi_value result;
-    napi_get_boolean(env, true, &result);
-    return result;
+napi_value UpdateSyncStatusWrapper(napi_env env, napi_callback_info args) {
+    return NAPI_SAFE_WRAP(env, args, update_sync_status_wrapper);
 }
 
 napi_value GetPlaceholderStateWrapper(napi_env env, napi_callback_info args) {

native-src/virtual_drive/Wrappers.cpp

@@ -0,0 +1,21 @@
+#include <windows.h>
+#include "Placeholders.h"
+
+napi_value update_sync_status_wrapper(napi_env env, napi_callback_info info) {
+    size_t argc = 3;
+    napi_value argv[3];
+    napi_get_cb_info(env, info, &argc, argv, nullptr, nullptr);
+
+    size_t pathLength;
+    napi_get_value_string_utf16(env, argv[0], nullptr, 0, &pathLength);
+    std::unique_ptr<wchar_t[]> widePath(new wchar_t[pathLength + 1]);
+    napi_get_value_string_utf16(env, argv[0], reinterpret_cast<char16_t *>(widePath.get()), pathLength + 1, nullptr);
+
+    bool inputSyncState, isDirectory;
+    napi_get_value_bool(env, argv[1], &inputSyncState);
+    napi_get_value_bool(env, argv[2], &isDirectory);
+
+    Placeholders::UpdateSyncStatus(widePath.get(), inputSyncState, isDirectory);
+
+    return nullptr;
+}