Skip to content

Commit d797b38

Browse files
fix: resolve lint and build-package CI failures
- Apply prettier formatting fixes - Exclude __tests__ from tsconfig.build.json so bob build doesn't try to generate type definitions for test files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f534f55 commit d797b38

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

__tests__/withAndroidPushNotifications.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ describe('withAndroidPushNotifications', () => {
8787
expect(content).toContain(
8888
'IntercomModule.sendTokenToIntercom(application, refreshedToken)'
8989
);
90-
expect(content).toContain(
91-
'IntercomModule.isIntercomPush(remoteMessage)'
92-
);
90+
expect(content).toContain('IntercomModule.isIntercomPush(remoteMessage)');
9391
expect(content).toContain(
9492
'IntercomModule.handleRemotePushMessage(application, remoteMessage)'
9593
);
@@ -205,7 +203,7 @@ describe('withAndroidPushNotifications', () => {
205203
const warnSpy = jest.spyOn(console, 'warn').mockImplementation();
206204

207205
config.modResults.manifest.application[0].service.push({
208-
$: {
206+
'$': {
209207
'android:name': '.ExistingFcmService',
210208
'android:exported': 'true',
211209
},

src/expo-plugins/withAndroidPushNotifications.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,9 @@ const registerServiceInManifest: ConfigPlugin<IntercomPluginProps> = (
8686
_config
8787
) =>
8888
withAndroidManifest(_config, (config) => {
89-
const mainApplication =
90-
AndroidConfig.Manifest.getMainApplicationOrThrow(config.modResults);
89+
const mainApplication = AndroidConfig.Manifest.getMainApplicationOrThrow(
90+
config.modResults
91+
);
9192

9293
const packageName = config.android?.package;
9394
if (!packageName) {
@@ -105,11 +106,12 @@ const registerServiceInManifest: ConfigPlugin<IntercomPluginProps> = (
105106
const hasExistingFcmService = mainApplication.service?.some(
106107
(s) =>
107108
s.$?.['android:name'] !== serviceName &&
108-
s['intent-filter']?.some((f: any) =>
109-
f.action?.some(
110-
(a: any) =>
111-
a.$?.['android:name'] === 'com.google.firebase.MESSAGING_EVENT'
112-
)
109+
s['intent-filter']?.some(
110+
(f: any) =>
111+
f.action?.some(
112+
(a: any) =>
113+
a.$?.['android:name'] === 'com.google.firebase.MESSAGING_EVENT'
114+
)
113115
)
114116
);
115117

@@ -128,7 +130,7 @@ const registerServiceInManifest: ConfigPlugin<IntercomPluginProps> = (
128130
}
129131

130132
mainApplication.service.push({
131-
$: {
133+
'$': {
132134
'android:name': serviceName,
133135
'android:exported': 'false' as any,
134136
},

tsconfig.build.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"extends": "./tsconfig",
3-
"exclude": ["examples/*"]
3+
"exclude": ["examples/*", "__tests__"]
44
}

0 commit comments

Comments
 (0)