Skip to content

Commit 8614031

Browse files
Fixing more tests for required fields changes
1 parent a3592a0 commit 8614031

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

src/test/java/com/intercom/api/integration/DataAttributesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void before() {
4444
ObjectMappers.JSON_MAPPER.convertValue(createRequestData, CreateDataAttributeRequest.class);
4545

4646
dataAttribute = client.dataAttributes().create(createRequest);
47-
dataAttributeId = dataAttribute.getId().orElseThrow(() -> new RuntimeException("dataAttribute.id is required"));
47+
dataAttributeId = Integer.parseInt(dataAttribute.getId());
4848
}
4949

5050
@Test

src/test/java/com/intercom/api/integration/IntegrationTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ public void before() {
6161
.create(CreateContactRequest.of(CreateContactRequest.WithExternalId.builder()
6262
.externalId(Utils.randomString())
6363
.build()));
64-
userId = user.getId().orElseThrow(() -> new RuntimeException("User ID is required"));
64+
userId = user.getId();
6565
lead = client.contacts()
6666
.create(CreateContactRequest.of(CreateContactRequest.WithRole.builder()
6767
.role("lead")
6868
.name("Marek Barek")
6969
.build()));
70-
leadId = lead.getId().orElseThrow(() -> new RuntimeException("Lead ID is required"));
70+
leadId = lead.getId();
7171
tag = client.tags()
7272
.create(TagsCreateRequestBody.of(CreateOrUpdateTagRequest.builder()
7373
.name(Utils.randomString())
@@ -126,8 +126,7 @@ public void testTagConversation() {
126126
// act
127127
Tag response = client.tags()
128128
.tagConversation(TagConversationRequest.builder()
129-
.conversationId(message.getConversationId()
130-
.orElseThrow(() -> new RuntimeException("Conversation ID is required")))
129+
.conversationId(message.getConversationId())
131130
.tagId(tag.getId())
132131
.adminId(adminId)
133132
.build());

src/test/java/com/intercom/api/integration/MessagesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void before() {
4242
.externalId(Utils.randomString())
4343
.name("Message Test User")
4444
.build()));
45-
userId = user.getId().orElseThrow(() -> new RuntimeException("User ID is required"));
45+
userId = user.getId();
4646
}
4747

4848
@AfterEach

src/test/java/com/intercom/api/integration/SegmentsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void before() {
2424
.getSegments()
2525
.orElseThrow(() -> new RuntimeException("Segments list is required"))
2626
.get(0);
27-
segmentId = segment.getId().orElseThrow(() -> new RuntimeException("Segment ID is required"));
27+
segmentId = segment.getId();
2828
}
2929

3030
@Test

0 commit comments

Comments
 (0)