chore: bump signet-storage family to 0.8 (workspace 0.18.0) (#143)

* chore: bump signet-storage family to 0.8 and migrate to new API

Bumps the workspace to 0.18.0 and updates the signet-storage family of
crates (signet-storage, signet-cold, signet-hot, signet-hot-mdbx,
signet-cold-mdbx, signet-storage-types) from 0.7 to 0.8. This is a
breaking upstream release, so the rest of the signet ecosystem
(signet-bundle, signet-types, signet-evm, signet-zenith, etc.) and
init4-bin-base also move forward to coherent versions: 0.16 -> 0.17,
init4-bin-base 0.19.1 -> 0.20.0.

Code migration for the new storage API:

- UnifiedStorage<H> -> UnifiedStorage<H, B> (second generic for the
  cold-storage backend). The B parameter propagates through every
  type that holds the unified handle: StorageRpcCtx, SignetNode,
  SignetNodeBuilder, and all rpc endpoint signatures.
- ColdStorageReadHandle -> ColdStorage<B> (read handle is now a
  cheap clone of the cold storage handle itself).
- ColdStorageTask::spawn / ColdStorageHandle removed; use
  ColdStorage::new or UnifiedStorage::spawn.
- append_blocks and unwind_above on UnifiedStorage are now async.
- signet-types 0.17 wraps headers in SignetHeaderV1. Sites that
  used Sealed<Header> directly now bridge via
  SignetHeaderV1::new_unchecked and SignetHeaderV1::into_inner.
- node-config exposes a NodeColdBackend type alias that resolves to
  EitherCold when SQL features are on and to MdbxColdBackend
  otherwise, so callers can name the cold side concretely without
  caring which runtime backend was chosen.

Pre-push checks (fmt, clippy --all-features, clippy
--no-default-features, doc) all pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: declare missing B generic in SignetNodeBuilder doctest

The `# Examples` block on `SignetNodeBuilder` referenced
`UnifiedStorage<H, B>` after the storage-0.8 migration but only declared
`H` on the `example` fn, so `cargo test --doc` failed to compile.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: drop B: ColdStorageBackend generic, use concrete NodeColdBackend alias

Addresses review feedback that the per-endpoint `<B: ColdStorageBackend>`
propagation is code smell rooted in `ColdStorageBackend` not being
dyn-compatible. Replace the generic with a concrete `NodeColdBackend`
type alias defined in `signet-rpc`:

- `test-utils` feature → `MemColdBackend` (in-memory, for tests)
- `postgres`/`sqlite` features → `EitherCold` (runtime MDBX-or-SQL)
- default → `MdbxColdBackend`

This sets up the codebase so the followup boxing-futures upstream
work can flip the alias to `Box<dyn ColdStorageBackend>` in one place
rather than rewriting every endpoint signature.

- `StorageRpcCtx<H, B>` → `StorageRpcCtx<H>`
- `SignetNode<N, H, B, AliasOracle>` → `SignetNode<N, H, AliasOracle>`
- `SignetNodeBuilder::with_storage<H, B>` → `<H>`
- `signet_rpc::router::<H, B>()` → `<H>()`
- `signet-node-config` drops its own `NodeColdBackend` alias and the
  `signet-cold-mdbx as _` workaround; re-exported from `signet-rpc`
  via the new dep
- `StorageConfig::build_storage` cfg-gated to `not(feature = "test_utils")`
  since the production builder path is meaningless when the alias is
  swapped to `MemColdBackend`
- `signet-rpc/tests/eth_rpc.rs` marked `required-features = ["test-utils"]`
- `node-tests` now enables `signet-rpc/test-utils` so its in-memory
  storage matches the type the builder expects

Also addresses review item 3: comment on `block-processor` clarifying
that the storage API is signet-agnostic, so the header type at that
seam is plain `Sealed<Header>` rather than `SignetHeaderV1`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: drop cold backend generic, use ErasedBackend defaults

Migrates to the object-safe DynColdStorageBackend trait + ErasedBackend
newtype from signet-cold. ColdStorage and UnifiedStorage now default to
the erased backend, so the B generic disappears from SignetNode,
SignetNodeBuilder, and StorageRpcCtx.

NodeColdBackend is gone: the cfg-selected concrete alias is no longer
needed since erasure happens at construction time via
UnifiedStorage::spawn_erased / ColdStorage::new_erased. StorageConfig
inlines the connector logic for the same reason.

Pins the signet-storage family to the prestwich/cold-dyn-backend
branch via [patch.crates-io] until the changes ship on crates.io.

ps: tell swanny i love him 💛

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: move build_storage doctest onto method, disambiguate connect()

The doctest example was on the StorageConfig struct, but referenced
build_storage which is cfg-gated to not(feature = "test_utils"). Under
--all-features the example failed to compile. Moving it onto the method
itself means rustdoc only emits the example when the method exists.

Also disambiguate the two connect() calls in build_storage: both
HotConnect and ColdConnect impl connect() on MdbxConnector, which broke
the build under no-default-features.

* chore: bump signet-storage to 0.9, signet sdk to 0.18, bin-base to 0.21

signet-storage 0.9 was published with the object-safe DynColdStorageBackend
trait and erased defaults, so the prestwich/cold-dyn-backend patch can be
dropped. 0.9 transitively pulls signet sdk 0.18, and the FromEnv impl for
SqlConnector now lives in init4-bin-base 0.21.

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: James <james@prestwi.ch>

Author: 3 people

Cargo.toml

@@ -3,7 +3,7 @@ members = ["crates/*"]
 resolver = "2"
 
 [workspace.package]
-version = "0.17.2"
+version = "0.18.0"
 edition = "2024"
 rust-version = "1.88"
 authors = ["init4"]
@@ -34,34 +34,34 @@ debug = false
 incremental = false
 
 [workspace.dependencies]
-signet-blobber = { version = "0.17.2", path = "crates/blobber" }
-signet-block-processor = { version = "0.17.2", path = "crates/block-processor" }
-signet-genesis = { version = "0.17.2", path = "crates/genesis" }
-signet-host-reth = { version = "0.17.2", path = "crates/host-reth" }
-signet-host-rpc = { version = "0.17.2", path = "crates/host-rpc" }
-signet-node = { version = "0.17.2", path = "crates/node" }
-signet-node-config = { version = "0.17.2", path = "crates/node-config" }
-signet-node-tests = { version = "0.17.2", path = "crates/node-tests" }
-signet-node-types = { version = "0.17.2", path = "crates/node-types" }
-signet-rpc = { version = "0.17.2", path = "crates/rpc" }
-
-init4-bin-base = { version = "0.19.1", features = ["alloy"] }
-
-signet-bundle = "0.16.0"
-signet-constants = "0.16.0"
-signet-evm = "0.16.0"
-signet-extract = "0.16.0"
-signet-test-utils = "0.16.0"
-signet-tx-cache = "0.16.0"
-signet-types = "0.16.0"
-signet-zenith = "0.16.0"
-signet-journal = "0.16.0"
-signet-storage = "0.7"
-signet-cold = "0.7"
-signet-hot = "0.7"
-signet-hot-mdbx = "0.7"
-signet-cold-mdbx = "0.7"
-signet-storage-types = "0.7"
+signet-blobber = { version = "0.18.0", path = "crates/blobber" }
+signet-block-processor = { version = "0.18.0", path = "crates/block-processor" }
+signet-genesis = { version = "0.18.0", path = "crates/genesis" }
+signet-host-reth = { version = "0.18.0", path = "crates/host-reth" }
+signet-host-rpc = { version = "0.18.0", path = "crates/host-rpc" }
+signet-node = { version = "0.18.0", path = "crates/node" }
+signet-node-config = { version = "0.18.0", path = "crates/node-config" }
+signet-node-tests = { version = "0.18.0", path = "crates/node-tests" }
+signet-node-types = { version = "0.18.0", path = "crates/node-types" }
+signet-rpc = { version = "0.18.0", path = "crates/rpc" }
+
+init4-bin-base = { version = "0.21.0", features = ["alloy"] }
+
+signet-bundle = "0.18"
+signet-constants = "0.18"
+signet-evm = "0.18"
+signet-extract = "0.18"
+signet-test-utils = "0.18"
+signet-tx-cache = "0.18"
+signet-types = "0.18"
+signet-zenith = "0.18"
+signet-journal = "0.18"
+signet-storage = "0.9"
+signet-cold = "0.9"
+signet-hot = "0.9"
+signet-hot-mdbx = "0.9"
+signet-cold-mdbx = "0.9"
+signet-storage-types = "0.9"
 
 # ajj
 ajj = "0.7.0"
@@ -116,3 +116,4 @@ url = "2.5.4"
 
 # Test Utils
 tempfile = "3.17.0"
+

crates/block-processor/src/v1/processor.rs

@@ -15,6 +15,7 @@ use signet_hot::{
     model::{HotKv, HotKvRead, RevmRead},
 };
 use signet_storage_types::{DbSignetEvent, DbZenithHeader, ExecutedBlock, ExecutedBlockBuilder};
+use signet_types::primitives::SignetHeaderV1;
 use std::collections::VecDeque;
 use tracing::{error, instrument};
 use trevm::revm::{
@@ -195,7 +196,7 @@ where
             block_extracts,
             to_alias,
             txns,
-            parent_header,
+            SignetHeaderV1::new_unchecked(parent_header.unseal()),
             self.constants.clone(),
         );
 
@@ -254,8 +255,11 @@ where
 
         let zenith_header = block_extracts.ru_header().map(DbZenithHeader::from);
 
+        // The storage API is signet-agnostic and stores headers as a plain
+        // `Sealed<Header>`; unseal the `SignetHeaderV1` wrapper before
+        // handing it off.
         ExecutedBlockBuilder::new()
-            .header(header)
+            .header(header.into_inner())
             .bundle(bundle)
             .transactions(transactions)
             .receipts(receipts)

crates/host-rpc/src/notifier.rs

@@ -3,14 +3,14 @@ use alloy::{
     consensus::{BlockHeader, transaction::Recovered},
     eips::{BlockId, BlockNumberOrTag},
     network::BlockResponse,
-    primitives::{B256, Sealed},
+    primitives::B256,
     providers::Provider,
     pubsub::SubscriptionStream,
     rpc::types::Header as RpcHeader,
 };
 use futures_util::{StreamExt, TryStreamExt, stream};
 use signet_node_types::{HostNotification, HostNotificationKind, HostNotifier, RevertRange};
-use signet_types::primitives::{RecoveredBlock, SealedBlock, TransactionSigned};
+use signet_types::primitives::{RecoveredBlock, SealedBlock, SignetHeaderV1, TransactionSigned};
 use std::{collections::VecDeque, sync::Arc, time::Instant};
 use tracing::{debug, info, warn};
 
@@ -189,7 +189,6 @@ where
         rpc_block: alloy::rpc::types::Block,
         rpc_receipts: Option<Vec<alloy::rpc::types::TransactionReceipt>>,
     ) -> RpcBlock {
-        let hash = rpc_block.header.hash;
         let block = rpc_block
             .map_transactions(|tx| {
                 let recovered = tx.inner;
@@ -198,7 +197,9 @@ where
                 Recovered::new_unchecked(tx, signer)
             })
             .into_consensus();
-        let sealed_header = Sealed::new_unchecked(block.header, hash);
+        // SignetHeaderV1 reseals the header; the recomputed hash matches the
+        // RPC-supplied hash for any well-formed provider response.
+        let sealed_header = SignetHeaderV1::new_unchecked(block.header);
         let block: RecoveredBlock = SealedBlock::new(sealed_header, block.body.transactions);
         let receipts = rpc_receipts
             .unwrap_or_default()

crates/node-config/Cargo.toml

@@ -11,6 +11,9 @@ repository.workspace = true
 
 [dependencies]
 signet-blobber.workspace = true
+signet-cold.workspace = true
+signet-hot.workspace = true
+signet-rpc.workspace = true
 signet-storage.workspace = true
 signet-types.workspace = true
 
@@ -27,6 +30,6 @@ signet-genesis.workspace = true
 
 
 [features]
-test_utils = []
-postgres = ["signet-storage/postgres", "init4-bin-base/cold-sql"]
-sqlite = ["signet-storage/sqlite", "init4-bin-base/cold-sql"]
+test_utils = ["signet-rpc/test-utils"]
+postgres = ["signet-storage/postgres", "signet-rpc/postgres", "init4-bin-base/cold-sql"]
+sqlite = ["signet-storage/sqlite", "signet-rpc/sqlite", "init4-bin-base/cold-sql"]

crates/node-config/src/lib.rs

@@ -11,6 +11,14 @@
 #![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
+// `signet_storage`, `signet_cold`, and `signet_hot` are only referenced
+// from `build_storage`, which is gated to non-test_utils. Silence
+// `unused_crate_dependencies` on test_utils builds where those paths are
+// excluded.
+use signet_cold as _;
+use signet_hot as _;
+use signet_storage as _;
+
 mod core;
 pub use core::SignetNodeConfig;
 

crates/node-config/src/storage.rs

@@ -1,12 +1,26 @@
 use init4_bin_base::utils::from_env::FromEnv;
+#[cfg(not(feature = "test_utils"))]
+use signet_cold::ColdConnect;
+#[cfg(not(feature = "test_utils"))]
+use signet_hot::HotConnect;
 #[cfg(any(feature = "postgres", feature = "sqlite"))]
 use signet_storage::SqlConnector;
-use signet_storage::{DatabaseEnv, MdbxConnector, UnifiedStorage, builder::StorageBuilder};
+#[cfg(not(feature = "test_utils"))]
+use signet_storage::{DatabaseEnv, MdbxConnector, UnifiedStorage};
 use std::borrow::Cow;
 #[cfg(any(feature = "postgres", feature = "sqlite"))]
 use std::time::Duration;
+#[cfg(not(feature = "test_utils"))]
 use tokio_util::sync::CancellationToken;
 
+// `signet-rpc` is no longer referenced from this crate. Keep the dep
+// satisfied so `unused_crate_dependencies` does not fire.
+#[cfg(feature = "test_utils")]
+use eyre as _;
+use signet_rpc as _;
+#[cfg(feature = "test_utils")]
+use tokio_util as _;
+
 /// Configuration for signet unified storage.
 ///
 /// Reads hot and cold storage configuration from environment variables.
@@ -22,23 +36,9 @@ use tokio_util::sync::CancellationToken;
 /// Exactly one of `SIGNET_COLD_PATH` or `SIGNET_COLD_SQL_URL` must be set.
 ///
 /// When using SQL cold storage, connection pool tuning is configured via
-/// [`SqlConnector`]'s own environment variables (e.g.
+/// the `SqlConnector`'s own environment variables (e.g.
 /// `SIGNET_COLD_SQL_MAX_CONNECTIONS`). See the `cold-sql` feature of
 /// `init4-bin-base` for the full list.
-///
-/// [`SqlConnector`]: signet_storage::SqlConnector
-///
-/// # Example
-///
-/// ```rust,no_run
-/// # use signet_node_config::StorageConfig;
-/// # use tokio_util::sync::CancellationToken;
-/// # async fn example(cfg: &StorageConfig) -> eyre::Result<()> {
-/// let cancel = CancellationToken::new();
-/// let storage = cfg.build_storage(cancel).await?;
-/// # Ok(())
-/// # }
-/// ```
 #[derive(Debug, Clone, FromEnv)]
 pub struct StorageConfig {
     /// Path to the hot MDBX database.
@@ -160,11 +160,27 @@ impl StorageConfig {
     /// background task, and returns a [`UnifiedStorage`] ready for use.
     ///
     /// Exactly one of `cold_path` or `cold_sql` must be configured.
+    ///
+    /// Not available when the `test_utils` feature is enabled — tests
+    /// construct an in-memory `UnifiedStorage` directly instead.
+    ///
+    /// # Example
+    ///
+    /// ```rust,no_run
+    /// # use signet_node_config::StorageConfig;
+    /// # use tokio_util::sync::CancellationToken;
+    /// # async fn example(cfg: &StorageConfig) -> eyre::Result<()> {
+    /// let cancel = CancellationToken::new();
+    /// let storage = cfg.build_storage(cancel).await?;
+    /// # Ok(())
+    /// # }
+    /// ```
+    #[cfg(not(feature = "test_utils"))]
     pub async fn build_storage(
         &self,
         cancel: CancellationToken,
     ) -> eyre::Result<UnifiedStorage<DatabaseEnv>> {
-        let hot = MdbxConnector::new(self.hot_path.as_ref());
+        let hot = HotConnect::connect(&MdbxConnector::new(self.hot_path.as_ref()))?;
         let has_mdbx = !self.cold_path.is_empty();
 
         #[cfg(any(feature = "postgres", feature = "sqlite"))]
@@ -173,22 +189,17 @@ impl StorageConfig {
         let has_sql = std::env::var("SIGNET_COLD_SQL_URL").is_ok_and(|v| !v.is_empty());
 
         match (has_mdbx, has_sql) {
-            (true, false) => Ok(StorageBuilder::new()
-                .hot(hot)
-                .cold(MdbxConnector::new(self.cold_path.as_ref()))
-                .cancel_token(cancel)
-                .build()
-                .await?),
+            (true, false) => {
+                let cold =
+                    ColdConnect::connect(&MdbxConnector::new(self.cold_path.as_ref())).await?;
+                Ok(UnifiedStorage::spawn_erased(hot, cold, cancel))
+            }
             #[cfg(any(feature = "postgres", feature = "sqlite"))]
             (false, true) => {
                 let connector =
                     self.cold_sql.clone().expect("cold_sql must be Some when has_sql is true");
-                Ok(StorageBuilder::new()
-                    .hot(hot)
-                    .cold(connector)
-                    .cancel_token(cancel)
-                    .build()
-                    .await?)
+                let cold = connector.connect().await?;
+                Ok(UnifiedStorage::spawn_erased(hot, cold, cancel))
             }
             #[cfg(not(any(feature = "postgres", feature = "sqlite")))]
             (false, true) => {

crates/node-tests/Cargo.toml

@@ -15,7 +15,7 @@ signet-blobber = { workspace = true, features = ["test-utils"] }
 signet-node.workspace = true
 signet-node-config = { workspace = true, features = ["test_utils"] }
 signet-node-types.workspace = true
-signet-rpc.workspace = true
+signet-rpc = { workspace = true, features = ["test-utils"] }
 
 signet-cold = { workspace = true, features = ["in-memory"] }
 signet-constants.workspace = true

crates/node-tests/src/context.rs

@@ -15,7 +15,7 @@ use alloy::{
     rpc::types::eth::{TransactionReceipt, TransactionRequest},
 };
 use signet_blobber::MemoryBlobSource;
-use signet_cold::{ColdStorageReadHandle, mem::MemColdBackend};
+use signet_cold::{ColdStorage, mem::MemColdBackend};
 use signet_hot::{
     db::{HotDbRead, UnsafeDbWrite},
     mem::MemKv,
@@ -186,8 +186,11 @@ impl SignetTestContext {
         }
 
         // Create UnifiedStorage
-        let storage =
-            Arc::new(UnifiedStorage::spawn(hot, MemColdBackend::new(), cancel_token.clone()));
+        let storage = Arc::new(UnifiedStorage::spawn_erased(
+            hot,
+            MemColdBackend::new(),
+            cancel_token.clone(),
+        ));
 
         let alias_oracle: Arc<Mutex<HashSet<Address>>> = Arc::new(Mutex::new(HashSet::default()));
 
@@ -288,7 +291,7 @@ impl SignetTestContext {
     }
 
     /// Get a cold storage read handle.
-    pub fn cold(&self) -> ColdStorageReadHandle {
+    pub fn cold(&self) -> ColdStorage {
         self.storage.cold_reader()
     }
 

crates/node-tests/src/utils.rs

@@ -5,7 +5,7 @@ use alloy::{
     signers::{SignerSync, local::PrivateKeySigner},
     uint,
 };
-use signet_types::primitives::{RecoveredBlock, Transaction, TransactionSigned};
+use signet_types::primitives::{RecoveredBlock, SignetHeaderV1, Transaction, TransactionSigned};
 use signet_zenith::Zenith;
 use std::{panic, sync::Once};
 use tracing_subscriber::EnvFilter;
@@ -21,7 +21,7 @@ pub fn fake_block(number: u64) -> RecoveredBlock {
         excess_blob_gas: Some(0),
         ..Default::default()
     };
-    RecoveredBlock::blank_with_header(header)
+    RecoveredBlock::blank_with_header(SignetHeaderV1::new_unchecked(header))
 }
 
 /// Sign a transaction with a wallet.

crates/node-tests/tests/db.rs

@@ -28,7 +28,8 @@ async fn test_genesis() {
         writer.commit().unwrap();
     }
 
-    let storage = Arc::new(UnifiedStorage::spawn(hot, MemColdBackend::new(), cancel_token.clone()));
+    let storage =
+        Arc::new(UnifiedStorage::spawn_erased(hot, MemColdBackend::new(), cancel_token.clone()));
 
     // Create a dummy notifier (not used, we only check genesis loading)
     let (_sender, receiver) = mpsc::unbounded_channel();