Major change: C ABI is now thread safe, and protects against bad

bindings!

Author: lilith

bindings/headers/imageflow_default.h

@@ -67,7 +67,7 @@ bool imageflow_context_add_input_buffer(struct imageflow_context *context,
 // The  buffer will be freed with the context.
 //
 //
-// Returns null if allocation failed; check the context for error details.
+// Returns false if allocation failed or context is damaged; check the context for error details.
 bool imageflow_context_add_output_buffer(struct imageflow_context *context, int32_t io_id);
 
 // Begins the process of destroying the context, yet leaves error information intact
@@ -91,7 +91,7 @@ bool imageflow_context_begin_terminate(struct imageflow_context *context);
 //
 // Returns a null pointer if allocation fails or the provided interface version is incompatible
 struct imageflow_context *imageflow_context_create(uint32_t imageflow_abi_ver_major,
-                                  uint32_t imageflow_abi_ver_minor);
+                                            uint32_t imageflow_abi_ver_minor);
 
 // Destroys the imageflow context and frees the context object.
 // Only use this with contexts created using `imageflow_context_create`
@@ -165,6 +165,7 @@ bool imageflow_context_error_write_to_buffer(struct imageflow_context *context,
 //
 // Provides access to the underlying buffer for the given io id
 //
+// Returns false and sets the error if the io id is invalid, the result buffer pointers are null, or the context is damaged.
 bool imageflow_context_get_output_buffer_by_id(struct imageflow_context *context,
                                                int32_t io_id,
                                                const uint8_t **result_buffer,

bindings/headers/imageflow_lua.h

@@ -60,7 +60,7 @@ bool imageflow_context_add_input_buffer(struct imageflow_context *context,
 // The  buffer will be freed with the context.
 //
 //
-// Returns null if allocation failed; check the context for error details.
+// Returns false if allocation failed or context is damaged; check the context for error details.
 bool imageflow_context_add_output_buffer(struct imageflow_context *context, int32_t io_id);
 
 // Begins the process of destroying the context, yet leaves error information intact
@@ -84,7 +84,7 @@ bool imageflow_context_begin_terminate(struct imageflow_context *context);
 //
 // Returns a null pointer if allocation fails or the provided interface version is incompatible
 struct imageflow_context *imageflow_context_create(uint32_t imageflow_abi_ver_major,
-                                  uint32_t imageflow_abi_ver_minor);
+                                            uint32_t imageflow_abi_ver_minor);
 
 // Destroys the imageflow context and frees the context object.
 // Only use this with contexts created using `imageflow_context_create`
@@ -158,6 +158,7 @@ bool imageflow_context_error_write_to_buffer(struct imageflow_context *context,
 //
 // Provides access to the underlying buffer for the given io id
 //
+// Returns false and sets the error if the io id is invalid, the result buffer pointers are null, or the context is damaged.
 bool imageflow_context_get_output_buffer_by_id(struct imageflow_context *context,
                                                int32_t io_id,
                                                const uint8_t **result_buffer,

bindings/headers/imageflow_pinvoke.h

@@ -67,7 +67,7 @@ bool imageflow_context_add_input_buffer(void *context,
 // The  buffer will be freed with the context.
 //
 //
-// Returns null if allocation failed; check the context for error details.
+// Returns false if allocation failed or context is damaged; check the context for error details.
 bool imageflow_context_add_output_buffer(void *context, int32_t io_id);
 
 // Begins the process of destroying the context, yet leaves error information intact
@@ -91,7 +91,7 @@ bool imageflow_context_begin_terminate(void *context);
 //
 // Returns a null pointer if allocation fails or the provided interface version is incompatible
 void *imageflow_context_create(uint32_t imageflow_abi_ver_major,
-                                  uint32_t imageflow_abi_ver_minor);
+                                            uint32_t imageflow_abi_ver_minor);
 
 // Destroys the imageflow context and frees the context object.
 // Only use this with contexts created using `imageflow_context_create`
@@ -165,6 +165,7 @@ bool imageflow_context_error_write_to_buffer(void *context,
 //
 // Provides access to the underlying buffer for the given io id
 //
+// Returns false and sets the error if the io id is invalid, the result buffer pointers are null, or the context is damaged.
 bool imageflow_context_get_output_buffer_by_id(void *context,
                                                int32_t io_id,
                                                const uint8_t **result_buffer,

bindings/headers/imageflow_short.h

@@ -29,7 +29,7 @@ bool imageflow_context_add_output_buffer(void *context, int32_t io_id);
 bool imageflow_context_begin_terminate(void *context);
 
 void *imageflow_context_create(uint32_t imageflow_abi_ver_major,
-                                  uint32_t imageflow_abi_ver_minor);
+                                            uint32_t imageflow_abi_ver_minor);
 
 void imageflow_context_destroy(void *context);
 

imageflow_abi/build.rs

@@ -101,6 +101,13 @@ enum StructModification {
     //You can specify no prefix..
     Prefix { prefix: &'static str, style: Style },
 }
+fn rename_structs(s: String, pairs: &[(&str, &str)], style: Style) -> String {
+    let mut temp = s;
+    for (old_name, new_name) in pairs {
+        temp = rename_word_excluding_enum_members(temp, old_name, new_name, style);
+    }
+    temp
+}
 
 fn filter_structs(s: String, names: &[&str], how: StructModification) -> String {
     let mut temp = s;
@@ -154,7 +161,8 @@ fn filter_enums<'a, 'b>(s: String, names: &'a [&'a str], how: EnumModification)
 }
 
 static ENUM_NAMES: [&str; 4] = ["IoMode", "Direction", "Lifetime", "CleanupWith"];
-static STRUCT_NAMES: [&str; 4] = ["Job", "JobIo", "Context", "JsonResponse"];
+static STRUCT_NAMES: [&str; 5] = ["Job", "JobIo", "Context", "ThreadSafeContext", "JsonResponse"];
+static RENAME_STRUCTS: [(&str, &str); 1] = [("ThreadSafeContext", "Context")];
 
 #[derive(Copy, Clone, PartialEq, Debug)]
 enum Target {
@@ -267,7 +275,13 @@ fn generate(target: Target) -> String {
 
         let builder = cbindgen::Builder::new().with_config(config).with_crate(crate_dir);
         let s = generate_to_string(builder);
-        let temp = filter_enums(filter_structs(s, &STRUCT_NAMES, structs), &ENUM_NAMES, enums);
+        // let rename_style = match structs{
+        //     StructModification::Prefix { style , ..} => style,
+        //     _ => Style::Snake
+        // };
+        let renamed = rename_structs(s, &RENAME_STRUCTS, Style::Unchanged);
+        let temp =
+            filter_enums(filter_structs(renamed, &STRUCT_NAMES, structs), &ENUM_NAMES, enums);
         if no_preprocessor_directives {
             strip_preprocessor_directives(&temp)
         } else {