Skip to content

Bump to igraph/C 1.0.1 #2650

@krlmlr

Description

@krlmlr

Draft prompt, will create a skill for that prompt and refine it as we go. Want to do some splitting work before launching: #2621.

Review krlmlr/igraph@main...main-b-dev . Start by vendoring main from that repo. Not expecting substantial changes after vendoring; check if tests pass. Then, vendor commit by commit until reaching main-b-dev . For each commit, run a clean rebuild after git clean -fdx src (ccache is available) and run testthat tests. If rebuild fails, Stimulus might need adaptation, or the vendored code must be changed; create a patch file in this case. Adapt the implementation as needed to wrap the downstream code without changing our interface. Expose new arguments behind a ... gatekeeper that is checked with check_dots_empty() . Adopt new conventions of the C interface while providing fallbacks that match the current interface as closely as possible, guarded with lifecycle::signal_stage("superseded") . Try hard to find replacements to identically replicate existing behavior, perhaps by calling other igraph functions. When touching R code, replace all instances of .Call() outside of aaa-auto.R with _impl() calls when an igraph/C function is called; if it doesn't exist, adapt Stimulus definitions to provide it. Remove bespoke wrapper code in this case. Run devtools::document() before changing the code. Apply judgment before changing tests or updating snapshots, add comments in the code to document decisions. When all checks pass, run examples. If they run without error, do one more pass of rcmdcheck::rcmdcheck() before committing. Create one commit in this repo per upstream commit. Push to a branch that has the suffix -dev .

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions