fix: address PR review comments on table rendering

- Clone preset styles in resolveTableStyle to prevent mutation of shared TABLE_STYLES singletons across renders

- Use local pageBg from doc.theme.bg instead of caching stale _pageBg on the style object; remove _pageBg from TableStyle interface

- Use validated style.bodyFg for row text color with autoTextColor fallback, fixing dead code where bodyFg was corrected but never used

- Enable PDF visual tests on Windows via WSL pdftoppm

- Add install-pdf-deps Justfile recipe for Linux and Windows/WSL

- Regenerate golden baselines to match bodyFg rendering change

Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>

Author: simongdavies

.github/workflows/pr-validate.yml

@@ -74,9 +74,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install PDF test dependencies
-        run: |
-          sudo apt-get update -qq
-          sudo apt-get install -y -qq poppler-utils qpdf fonts-dejavu-core
+        run: just install-pdf-deps
 
       - name: Setup
         run: just setup

.github/workflows/update-golden.yml

@@ -60,9 +60,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install PDF test dependencies
-        run: |
-          sudo apt-get update -qq
-          sudo apt-get install -y -qq poppler-utils qpdf fonts-dejavu-core
+        run: just install-pdf-deps
 
       - name: Setup
         run: just setup

Justfile

@@ -256,6 +256,20 @@ fmt-all: fmt fmt-analysis-guest fmt-runtime
 test-all: test test-analysis-guest
     @echo "✅ All tests passed"
 
+# Pinned versions for reproducible golden baselines.
+# Update ALL THREE locations together: Justfile, pr-validate.yml, update-golden.yml
+PDF_DEPS := "poppler-utils=24.02.0-1ubuntu9.8 qpdf=11.9.0-1.1ubuntu0.1 fonts-dejavu-core=2.37-8"
+
+# Install PDF visual test dependencies (poppler-utils + fonts-dejavu-core).
+# On Windows, installs into WSL. On Linux, installs natively.
+[linux]
+install-pdf-deps:
+    sudo apt-get update -qq && sudo apt-get install -y -qq {{PDF_DEPS}}
+
+[windows]
+install-pdf-deps:
+    wsl bash -c "sudo apt-get update -qq && sudo apt-get install -y -qq {{PDF_DEPS}}"
+
 # PDF visual regression tests
 test-pdf-visual:
     npx vitest run tests/pdf-visual.test.ts

builtin-modules/pdf.json

@@ -3,8 +3,8 @@
   "description": "PDF 1.7 document generation — text, graphics, metadata, standard fonts. Flow-based layout for auto-paginating documents.",
   "author": "system",
   "mutable": false,
-  "sourceHash": "sha256:e6e604e51302ea45",
-  "dtsHash": "sha256:f30fba88bfe5f977",
+  "sourceHash": "sha256:fedd6d3bc7c638e8",
+  "dtsHash": "sha256:e56bc4be1f1d0cd1",
   "importStyle": "named",
   "hints": {
     "overview": "Generate PDF documents with text, shapes, and metadata. Uses PDF's 14 standard fonts (no embedding required). Coordinates are in points (72 points = 1 inch), with top-left origin.",

builtin-modules/src/pdf.ts

@@ -3015,8 +3015,6 @@ export interface TableStyle {
   borderColor: string;
   /** Border line width in points. */
   borderWidth: number;
-  /** Page background colour (set internally for contrast checking). */
-  _pageBg?: string;
 }
 
 /** Built-in table styles matching PPTX table styles. */
@@ -3378,9 +3376,11 @@ export function comparisonTable(opts: ComparisonTableOptions): PdfElement {
   return _createPdfElement("comparisonTable", data);
 }
 
-/** Resolve a style name or object to a TableStyle. */
+/** Resolve a style name or object to a TableStyle.
+ *  Preset styles are shallow-cloned so that contrast auto-correction
+ *  in renderTable never mutates the shared TABLE_STYLES singletons. */
 function resolveTableStyle(style?: string | TableStyle): TableStyle {
-  if (!style) return TABLE_STYLES.default;
+  if (!style) return { ...TABLE_STYLES.default };
   if (typeof style === "string") {
     const resolved = TABLE_STYLES[style];
     if (!resolved) {
@@ -3389,7 +3389,7 @@ function resolveTableStyle(style?: string | TableStyle): TableStyle {
         `Unknown table style "${style}". Valid styles: ${valid}.`,
       );
     }
-    return resolved;
+    return { ...resolved };
   }
   return style;
 }
@@ -3487,16 +3487,13 @@ function renderTable(
   const rowH = tableRowHeight(fontSize, compact);
   const headerH = rowH;
 
-  // Ensure page background is available for contrast checking
-  if (!style._pageBg) {
-    style._pageBg = doc.theme.bg;
-  }
-
   // ── Contrast auto-correction ─────────────────────────────────────
   // Automatically fix text colors that have poor contrast against the
   // page background. No errors — just silently correct to readable.
+  // Use a local pageBg derived from the current doc theme rather than
+  // caching on the style object (which could be stale across renders).
   const MIN_CONTRAST = 3.0;
-  const pageBg = style._pageBg || "FFFFFF";
+  const pageBg = doc.theme.bg || "FFFFFF";
 
   // If headerBg is too similar to pageBg, the header row won't stand out.
   // Swap to theme accent1 so the header is visually distinct.
@@ -3652,11 +3649,12 @@ function renderTable(
 
     // EVERY row gets an explicit fill — no transparent rows, no guessing
     const isAlt = !!(style.altRowBg && r % 2 === 1);
-    const rowBg = isAlt ? style.altRowBg : (style._pageBg || "FFFFFF");
+    const rowBg = isAlt ? style.altRowBg : pageBg;
     doc.drawRect(x, curY, totalWidth, rowH, { fill: rowBg });
 
-    // Text color computed against the ACTUAL fill we just drew
-    const rowFg = autoTextColor(rowBg);
+    // Prefer the validated body text color; fall back to an automatic
+    // contrast color if no explicit body foreground is configured.
+    const rowFg = style.bodyFg ?? autoTextColor(rowBg);
 
     // Cell text AFTER background
     const isBoldRow = rowBold?.[r] ?? false;

builtin-modules/src/types/ha-modules.d.ts

@@ -1102,8 +1102,6 @@ declare module "ha:pdf" {
       borderColor: string;
       /** Border line width in points. */
       borderWidth: number;
-      /** Page background colour (set internally for contrast checking). */
-      _pageBg?: string;
   }
   /** Built-in table styles matching PPTX table styles. */
   export declare const TABLE_STYLES: Record<string, TableStyle>;