Ensure Akka HTTP(S) interception correctly handles plain HTTP

If test URL is changed to plain HTTP the tests fail, but that's
expected, as Wiremock only supports HTTPS and Akka & Spring don't
support HTTP-over-HTTPS proxying correctly. HTTP Toolkit supports
both on the same port just fine though, so that's enough for now.

Might be worth investigating this further in future, but it's quite
tricky, not worth it until it causes a real world issue.

Author: pimterry

src/main/java/tech/httptoolkit/javaagent/advice/akka/OverrideHttpSettingsAdvice.java

@@ -20,7 +20,7 @@ public class OverrideHttpSettingsAdvice {
             // For 10.2+:
             ? ConnectionContext.httpsClient(HttpProxyAgent.getInterceptedSslContext())
             // For everything before then:
-            : akka.http.javadsl.ConnectionContext.https(HttpProxyAgent.getInterceptedSslContext());
+            : ConnectionContext.https(HttpProxyAgent.getInterceptedSslContext());
 
     @Advice.OnMethodEnter
     public static void beforeOutgoingConnection(
@@ -30,12 +30,14 @@ public static void beforeOutgoingConnection(
         // Change all new outgoing connections to use the proxy:
         clientSettings = clientSettings.withTransport(
             ClientTransport.httpsProxy(new InetSocketAddress(
-                    HttpProxyAgent.getAgentProxyHost(),
-                    HttpProxyAgent.getAgentProxyPort()
+                HttpProxyAgent.getAgentProxyHost(),
+                HttpProxyAgent.getAgentProxyPort()
             ))
         );
 
         // Change all new outgoing connections to trust our certificate:
-        connectionContext = interceptedConnectionContext;
+        if (connectionContext.isSecure()) {
+            connectionContext = OverrideHttpSettingsAdvice.interceptedConnectionContext;
+        }
     }
 }

src/main/java/tech/httptoolkit/javaagent/advice/akka/ResetPoolSetupAdvice.java

@@ -29,6 +29,8 @@ public static void afterConstructor(
         settings = settings.withTransport(interceptedProxyTransport);
 
         // Change all new outgoing connections to trust our certificate:
-        connContext = OverrideHttpSettingsAdvice.interceptedConnectionContext;
+        if (connContext.isSecure()) {
+            connContext = OverrideHttpSettingsAdvice.interceptedConnectionContext;
+        }
     }
 }

test-app/src/main/java/tech/httptoolkit/testapp/cases/AkkaHostClientCase.java

@@ -3,10 +3,12 @@
 import akka.NotUsed;
 import akka.actor.ActorSystem;
 import akka.actor.ExtendedActorSystem;
+import akka.http.javadsl.ConnectHttp;
 import akka.http.javadsl.HostConnectionPool;
 import akka.http.javadsl.Http;
 import akka.http.javadsl.model.HttpRequest;
 import akka.http.javadsl.model.HttpResponse;
+import akka.http.javadsl.model.Uri;
 import akka.japi.Pair;
 import akka.stream.javadsl.Flow;
 import akka.stream.javadsl.Sink;
@@ -28,9 +30,9 @@ public class AkkaHostClientCase extends ClientCase<
 
     @Override
     public Flow<Pair<HttpRequest, NotUsed>, Pair<Try<HttpResponse>, NotUsed>, HostConnectionPool> newClient(String url) throws Exception {
-        URI uri = new URI(url);
+        Uri uri = Uri.create(url);
         return new Http((ExtendedActorSystem) system)
-            .cachedHostConnectionPool(uri.getHost());
+            .cachedHostConnectionPoolHttps(ConnectHttp.toHost(uri)); // HTTPS required here, or HTTP is *always* used
     }
 
     @Override