Use SSLContext.getDefault() more now that it's guaranteed fixed

Without this, some of the existing advice logic needs to be able to reach
HttpProxyAgent, which fails in some environments. This avoids that entirely,
making runtime logic everywhere simpler & more reliable.

Also starts removing unnecessary extra try/catches, as it appears that
bytebuddy handles this for us by default anyway.

Author: pimterry

src/main/java/tech/httptoolkit/javaagent/advice/OverrideSslContextFieldAdvice.java

@@ -1,17 +1,16 @@
 package tech.httptoolkit.javaagent.advice;
 
 import net.bytebuddy.asm.Advice;
-import tech.httptoolkit.javaagent.HttpProxyAgent;
-
 import javax.net.ssl.SSLContext;
+import java.security.NoSuchAlgorithmException;
 
 public class OverrideSslContextFieldAdvice {
 
     @Advice.OnMethodEnter
     public static void beforeMethod(
             @Advice.FieldValue(value = "sslContext", readOnly = false) SSLContext sslContextField
-    ) {
-        sslContextField = HttpProxyAgent.getInterceptedSslContext();
+    ) throws NoSuchAlgorithmException {
+        sslContextField = SSLContext.getDefault();
     }
 
 }

src/main/java/tech/httptoolkit/javaagent/advice/apacheclient/ApacheSetSslSocketFactoryAdvice.java

@@ -1,15 +1,16 @@
 package tech.httptoolkit.javaagent.advice.apacheclient;
 
 import net.bytebuddy.asm.Advice;
-import tech.httptoolkit.javaagent.HttpProxyAgent;
 
+import javax.net.ssl.SSLContext;
 import java.lang.reflect.Field;
+import java.security.NoSuchAlgorithmException;
 import java.util.Arrays;
 
 public class ApacheSetSslSocketFactoryAdvice {
 
     @Advice.OnMethodEnter
-    public static void beforeCreateSocket(@Advice.This Object thisFactory) {
+    public static void beforeCreateSocket(@Advice.This Object thisFactory) throws Exception {
         // Before creating the socket - replace the SSL context so the new socket trusts us.
 
         boolean intercepted = false;
@@ -22,12 +23,8 @@ public static void beforeCreateSocket(@Advice.This Object thisFactory) {
                 field.setAccessible(true);
 
                 // Overwrite the socket factory with our own:
-                try {
-                    field.set(thisFactory, HttpProxyAgent.getInterceptedSslContext().getSocketFactory());
-                    intercepted = true;
-                } catch (IllegalAccessException e) {
-                    throw new RuntimeException("Could not intercept Apache HttpClient HTTPS sockets");
-                }
+                field.set(thisFactory, SSLContext.getDefault().getSocketFactory());
+                intercepted = true;
             } catch (NoSuchFieldException ignored) { }
         }
 

src/main/java/tech/httptoolkit/javaagent/advice/jettyclient/JettyReturnSslContextFactoryV10Advice.java

@@ -2,18 +2,17 @@
 
 import net.bytebuddy.asm.Advice;
 import org.eclipse.jetty.util.ssl.SslContextFactory;
-import tech.httptoolkit.javaagent.HttpProxyAgent;
+
+import javax.net.ssl.SSLContext;
 
 public class JettyReturnSslContextFactoryV10Advice {
     @Advice.OnMethodExit
-    public static void getSslContextFactory(@Advice.Return(readOnly = false) SslContextFactory.Client returnValue) {
+    public static void getSslContextFactory(
+            @Advice.Return(readOnly = false) SslContextFactory.Client returnValue
+    ) throws Exception {
         SslContextFactory.Client sslFactory = new SslContextFactory.Client();
-        sslFactory.setSslContext(HttpProxyAgent.getInterceptedSslContext());
-        try {
-            sslFactory.start();
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
+        sslFactory.setSslContext(SSLContext.getDefault());
+        sslFactory.start();
 
         returnValue = sslFactory;
     }

src/main/java/tech/httptoolkit/javaagent/advice/jettyclient/JettyReturnSslContextFactoryV9Advice.java

@@ -4,12 +4,16 @@
 import org.eclipse.jetty.util.ssl.SslContextFactory;
 import tech.httptoolkit.javaagent.HttpProxyAgent;
 
+import javax.net.ssl.SSLContext;
+
 public class JettyReturnSslContextFactoryV9Advice {
 
     @Advice.OnMethodExit
-    public static void getSslContextFactory(@Advice.Return(readOnly = false) SslContextFactory returnValue) {
+    public static void getSslContextFactory(
+            @Advice.Return(readOnly = false) SslContextFactory returnValue
+    ) throws Exception {
         SslContextFactory sslFactory = new JettyV9StubContextFactory();
-        sslFactory.setSslContext(HttpProxyAgent.getInterceptedSslContext());
+        sslFactory.setSslContext(SSLContext.getDefault());
         try {
             sslFactory.start();
         } catch (Exception e) {