Fix semver update version parsing to skip empty strings

pimterry · pimterry · commit af10040790a3 · 2025-09-12T17:47:10.000+02:00
Without this, for some insane reason "" is considered as 0.0.0 which
breaks update detection given a release with an empty name.
diff --git a/app/src/main/java/tech/httptoolkit/android/HttpToolkitApplication.kt b/app/src/main/java/tech/httptoolkit/android/HttpToolkitApplication.kt
@@ -298,7 +298,7 @@ private data class GithubRelease(
 )
 
 private fun tryParseSemver(version: String?): SemVer? = try {
-    if (version == null) null
+    if (version == null || version == "") null
     else SemVer.parse(
         // Strip leading 'v'
         version.replace(Regex("^v"), "")

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ private data class GithubRelease(`
`298`	`298`	`)`
`299`	`299`
`300`	`300`	`private fun tryParseSemver(version: String?): SemVer? = try {`
`301`		`- if (version == null) null`
	`301`	`+ if (version == null \|\| version == "") null`
`302`	`302`	`else SemVer.parse(`
`303`	`303`	`// Strip leading 'v'`
`304`	`304`	`version.replace(Regex("^v"), "")`