route-recognizer compile error: use of unstable library feature 'test'

[dvic]

Bug Report

Tide does not compile.

Code/Gist

cargo run --example hello on dd0bcfe

Environment

• Rust toolchain version(s): rustc 1.38.0-nightly (2d1a551e1 2019-08-08)
• OS: OSX 10.14.5

Possible Solution

Fix upstream?

Additional context/Screenshots

Error:

cargo run --example hello
   Compiling route-recognizer v0.1.12
   Compiling arc-swap v0.3.11
   Compiling humansize v1.1.0
   Compiling uuid v0.7.4
   Compiling termcolor v1.0.5
   Compiling glob v0.2.11
   Compiling antidote v1.0.0
   Compiling proc-macro2 v0.4.30
   Compiling syn v0.15.43
   Compiling rand_chacha v0.1.1
error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
   --> /Users/dvic/.cargo/registry/src/github.com-1ecc6299db9ec823/route-recognizer-0.1.12/src/nfa.rs:568:3
    |
568 | #[bench]
    |   ^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/50297
    = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
   --> /Users/dvic/.cargo/registry/src/github.com-1ecc6299db9ec823/route-recognizer-0.1.12/src/nfa.rs:582:3
    |
582 | #[bench]
    |   ^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/50297
    = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
   --> /Users/dvic/.cargo/registry/src/github.com-1ecc6299db9ec823/route-recognizer-0.1.12/src/nfa.rs:596:3
    |
596 | #[bench]
    |   ^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/50297
    = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
   --> /Users/dvic/.cargo/registry/src/github.com-1ecc6299db9ec823/route-recognizer-0.1.12/src/lib.rs:332:3
    |
332 | #[bench]
    |   ^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/50297
    = help: add `#![feature(test)]` to the crate attributes to enable

   Compiling unicase v1.4.2
error: aborting due to 4 previous errors

For more information about this error, try `rustc --explain E0658`.
error: Could not compile `route-recognizer`.
warning: build failed, waiting for other jobs to finish...
error: build failed```

[dvic]

PR is available upstream: http-rs/route-recognizer#25

Temporary solution would be (http-rs/route-recognizer#25 (comment)):

[patch.crates-io.route-recognizer]
git = "https://github.com/miller-time/route-recognizer.rs"
rev = "d7bc06d2dc58a2c59d8f2cfbee2ab23b8188700d"

[miller-time]

@dvic apparently crates.io won't accept a dependency via patch.

possibly related, I tried this in the iron router crate and travisCI couldn't find the dependency: iron/router#149

I'm not sure what the solution should be, sorry. 😞

[dvic]

That's weird.. Adding this to tide seems to solve the problem with route-recognizer:

[patch.crates-io]
route-recognizer = { git = "https://github.com/miller-time/route-recognizer.rs", rev = "d7bc06d2dc58a2c59d8f2cfbee2ab23b8188700d" }

The reason it doesn't work in iron/router#149 is probably related to something else? Rust version perhaps?

[miller-time]

@dvic I cloned tide and tried building with latest nightly. I don't get the warning that iron router gives me for some reason. But it can't seem to find the crate:

error[E0432]: unresolved import `route_recognizer`
 --> src/router/core.rs:7:5
  |
7 | use route_recognizer::{Match, Params, Router as MethodRouter};
  |     ^^^^^^^^^^^^^^^^ use of undeclared type or module `route_recognizer`

You're able to cargo +nightly build locally with that change?

EDIT - oops!

I was incorrectly removing dependencies.route-recognizer. This does build correctly if you don't make silly mistakes. 😀 I re-opened iron/router#149

[Nemo157]

route-recognizer 0.1.13 should fix this, it would be great if someone can submit a PR updating the minimum version that Tide requests.

[miller-time]

might be best done in #301 since I think that fixes a separate issue with nightly builds