Skip to content

Commit 90be7e7

Browse files
committed
Avoid ResourceWarning: Implicitly cleaning up <addinfourl ...>
Close the urllib.response.addinfourl by using a context manager. Without this: =================================== FAILURES =================================== _________________________________ test session _________________________________ /usr/lib64/python3.14/tempfile.py:484: in __del__ _warnings.warn(self.warn_message, ResourceWarning) E ResourceWarning: Implicitly cleaning up <addinfourl at 281473371898608 whose fp = <http.client.HTTPResponse object at 0xffff9fe82470>> The above exception was the direct cause of the following exception: /usr/lib/python3.14/site-packages/_pytest/runner.py:344: in from_call result: TResult | None = func() ^^^^^^ /usr/lib/python3.14/site-packages/_pytest/runner.py:246: in <lambda> lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ /usr/lib/python3.14/site-packages/pluggy/_hooks.py:512: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ /usr/lib/python3.14/site-packages/pluggy/_manager.py:120: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ /usr/lib/python3.14/site-packages/_pytest/logging.py:850: in pytest_runtest_call yield /usr/lib/python3.14/site-packages/_pytest/capture.py:900: in pytest_runtest_call return (yield) ^^^^^ /usr/lib/python3.14/site-packages/_pytest/skipping.py:263: in pytest_runtest_call return (yield) ^^^^^ /usr/lib/python3.14/site-packages/_pytest/unraisableexception.py:158: in pytest_runtest_call collect_unraisable(item.config) /usr/lib/python3.14/site-packages/_pytest/unraisableexception.py:79: in collect_unraisable raise errors[0] /usr/lib/python3.14/site-packages/_pytest/unraisableexception.py:67: in collect_unraisable warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) E pytest.PytestUnraisableExceptionWarning: Exception ignored while calling deallocator <function _TemporaryFileCloser.__del__ at 0xffffa6b34720>: None CPython reference: python/cpython@bad3cde
1 parent fd4f032 commit 90be7e7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

html5lib/tests/test_stream.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,9 @@ def makefile(self, _mode, _bufsize=None):
212212

213213
source = http_client.HTTPResponse(FakeSocket())
214214
source.begin()
215-
wrapped = urllib.response.addinfourl(source, source.msg, "http://example.com")
216-
stream = HTMLInputStream(wrapped)
217-
assert stream.charsUntil(" ") == "Text"
215+
with urllib.response.addinfourl(source, source.msg, "http://example.com") as wrapped:
216+
stream = HTMLInputStream(wrapped)
217+
assert stream.charsUntil(" ") == "Text"
218218

219219

220220
@pytest.mark.parametrize("inp,num",

0 commit comments

Comments
 (0)