feat: Check process.env.PORT var also before defaulting to 3000

[MathurAditya724]

This is more of a question/discussion

Should we also check the value of process.env.PORT value?

That is on this line - https://github.com/honojs/node-server/blob/main/src/server.ts#L25

We do -

options?.port ?? process.env.PORT ? Number.parseInt(process.env.PORT, 10) : 3000

I believe PORT is a general env variable for defining the port for a server in js ecosystem.

Feel free to close it if this doesn't seems necessary, happy to create a PR for this.

[usualoma]

There are no references to process.env in the existing code, so we need to determine whether it's acceptable to use it. Personally, I think specifying it via environment variables is fine.

[usualoma]

One approach could be to avoid referencing process.env in the main application itself, and instead only reference process.env within a utility layer like the one shown below.

#282

[yusukebe]

This is a trade-off between simplicity and convenience. I think we don't need it since process.env is not used in the current code, as @usualoma mentioned.

[MathurAditya724]

Yes, that is indeed cool. I didn't knew about that. Awesome work @usualoma

Closing this then