Skip to content

Commit fc84793

Browse files
committed
fix(ci): 🐛 test typescript-dev alone (installs essential-dev automatically)
- Remove essential-dev from features list in test matrix - typescript-dev declares essential-dev in installsAfter - CLI will install both features automatically
1 parent 5cd4a9e commit fc84793

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
baseImage: mcr.microsoft.com/devcontainers/typescript-node:20
5252

5353
# typescript-dev - requires VS Code (extensions only, no install.sh logic)
54-
# Tested with essential-dev as it's a dependency
55-
- features: essential-dev,typescript-dev
54+
# Will automatically install essential-dev via installsAfter dependency
55+
- features: typescript-dev
5656
baseImage: mcr.microsoft.com/devcontainers/typescript-node:20
5757

5858
# auto-header - works on any base image with bash and python3

src/typescript-dev/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.5",
44
"name": "TypeScript Development Environment",
55
"description": "TypeScript/JavaScript development setup with indexing, import management, HTML/CSS intelligence, and web tools. Requires essential-dev for Git, Copilot, and editor enhancements.",
6-
"documentationURL": "https://github.com/helpers4/devcontainer/tree/main/features/typescript-dev",
6+
"documentationURL": "https://github.com/helpers4/devcontainer/tree/main/src/typescript-dev",
77
"installsAfter": [
88
"ghcr.io/helpers4/devcontainer/essential-dev"
99
],

0 commit comments

Comments
 (0)