vuln-fix: Zip Slip Vulnerability

This fixes a Zip-Slip vulnerability.

This change does one of two things. This change either

1. Inserts a guard to protect against Zip Slip.
OR
2. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`.

For number 2, consider `"/usr/outnot".startsWith("/usr/out")`.
The check is bypassed although `/outnot` is not under the `/out` directory.
It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object.
For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`;
however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`.

Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')
Severity: High
CVSSS: 7.4
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-zipslip/) & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.ZipSlip)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: JLLeitschuh/security-research#16

Co-authored-by: Moderne <team@moderne.io>

Author: JLLeitschuh

compress-example/src/main/java/io/github/biezhi/compress/jar/JAR.java

@@ -36,6 +36,9 @@ public static void decompress(String in, File destination) throws IOException {
                     continue;
                 }
                 File curfile = new File(destination, entry.getName());
+                if (!curfile.toPath().normalize().startsWith(destination.toPath().normalize())) {
+                    throw new IOException("Bad zip entry");
+                }
                 File parent  = curfile.getParentFile();
                 if (!parent.exists()) {
                     if (!parent.mkdirs()) {
@@ -66,4 +69,4 @@ private static void addToArchiveCompression(JarArchiveOutputStream out, File fil
             System.out.println(file.getName() + " is not supported");
         }
     }
-}
+}

compress-example/src/main/java/io/github/biezhi/compress/zip/ZIP.java

@@ -34,6 +34,9 @@ public static void decompress(String in, File destination) throws IOException {
                     continue;
                 }
                 File curfile = new File(destination, entry.getName());
+                if (!curfile.toPath().normalize().startsWith(destination.toPath().normalize())) {
+                    throw new IOException("Bad zip entry");
+                }
                 File parent  = curfile.getParentFile();
                 if (!parent.exists()) {
                     if (!parent.mkdirs()) {