Better response error messages

Author: rweigel

CHANGES.txt

@@ -115,3 +115,4 @@ v0.2.8b0:
 	2026-05-02 -- Documentation
 v0.2.8b1:
 	2026-05-02 -- Versioning updates
+	2026-05-19 -- Better response error messages

hapiclient/util.py

@@ -330,30 +330,29 @@ def get_full_class_name(obj):
 
     c = " If problem persists, a contact email for the server may be listed "
     c = c + "at http://hapi-server.org/servers/"
-    msg = '';
+    msg = ''
     try:
         http = urllib3.PoolManager()
         res = http.request('GET', url, preload_content=False, retries=2)
         if res.status != 200:
+            msgo = "Problem with " + url + \
+                   ". Server responded with non-200 HTTP status (" + \
+                   str(res.status) + ") "
             try:
                 jres = load(res)
-            except Exception as e:
-                msg = "Problem with " + url + \
-                        ". Server responded with non-200 HTTP status (" \
-                        + str(res.status) + \
-                        ") and an invalid JSON in response body." + c
-
-            if msg == '' and 'status' in jres:
-                if 'message' in jres['status']:
-                    msg = '%s\n' % (jres['status']['message'])
+            except Exception:
+                msg = msgo + "and invalid JSON in response body." + c
 
             if msg == '':
-                msg = "Problem with " + url + \
-                      ". Server responded with non-200 HTTP status (" + \
-                      str(res.status) + \
-                      ") but no JSON without HAPI error message in response body." + c
-
-            raise HAPIError
+                if 'status' in jres:
+                    if 'message' in jres['status']:
+                        msg = msgo + 'and error message: %s\n' % (jres['status']['message'])
+                    else:
+                        msg = msgo + "and no error message in status element of response body." + c
+                else:
+                    msg = msgo + "and JSON without HAPI status in response body." + c
+
+            raise HAPIError(msg)
 
     except HAPIError:
         error(msg)