Skip to content

Commit 7a2d566

Browse files
authored
Merge branch 'main' into ui3
2 parents b7bf8bf + 4f069af commit 7a2d566

File tree

5 files changed

+41
-43
lines changed

5 files changed

+41
-43
lines changed

app/services/user_service/enroll_sms_auth.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,15 @@ def start_verification
1212
# doing this here to be safe.
1313
raise ArgumentError.new("phone number for user: #{@user.id} not in E.164 format") unless @user.phone_number =~ /\A\+[1-9]\d{1,14}\z/
1414

15+
disallow_fresh_users
16+
1517
TwilioVerificationService.new.send_verification_request(@user.phone_number)
1618
end
1719

1820
# Completing the phone number verification by checking that exchanging code works
1921
def complete_verification(verification_code)
22+
disallow_fresh_users
23+
2024
begin
2125
verified = TwilioVerificationService.new.check_verification_token(@user.phone_number, verification_code)
2226
rescue Twilio::REST::RestError
@@ -33,6 +37,8 @@ def enroll_sms_auth
3337
raise SMSEnrollmentError("user has no phone number") if @user.phone_number.blank?
3438
raise SMSEnrollmentError("user has not verified phone number") unless @user.phone_number_verified
3539

40+
disallow_fresh_users
41+
3642
@user.use_sms_auth = true
3743
@user.save!
3844
end
@@ -47,5 +53,11 @@ def disable_sms_auth
4753
class SMSEnrollmentError < StandardError
4854
end
4955

56+
def disallow_fresh_users
57+
return if @user.created_at < 1.day.ago
58+
59+
raise SMSEnrollmentError("Please wait at least 24 hours after creating your account before enrolling in SMS authentication.")
60+
end
61+
5062
end
5163
end
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<%# locals: (event:) %>
2+
3+
<% if event.donation_page_available? && event.is_public && !organizer_signed_in? %>
4+
<%= link_to start_donation_donations_path(event), target: "_blank", class: "btn bg-blue flex items-center" do %>
5+
<%= inline_icon "purse" %>
6+
Donate
7+
<% end %>
8+
<% end %>

app/views/events/_heading.html.erb

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<%# locals: (event:, event_follow: nil) %>
2+
3+
<h1 class="flex items-center gap-4">
4+
<%= yield %>
5+
<% admin_tool("badge", "span") do %>
6+
<span class="m0 badge bg-muted">
7+
#<%= event.id %>
8+
</span>
9+
<span class="m0 badge bg-muted ml1">
10+
SL<%= event.service_level %>
11+
</span>
12+
<% end %>
13+
14+
<%= render "events/follow_button", event:, event_follow: %>
15+
<%= render "events/donate_button", event: %>
16+
</h1>

app/views/events/show.html.erb

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,9 @@
2727
<% end %>
2828
<% end %>
2929

30-
<h1 class="flex items-center border-0 mb-0">
31-
<span class="flex-grow">
32-
<%= @event.name %>
33-
</span>
34-
<% admin_tool("p0 m2 my-0 badge bg-transparent", "span") do %>
35-
<span class="m0 badge bg-muted">
36-
#<%= @event.id %>
37-
</span>
38-
<span class="m0 badge bg-muted ml1">
39-
SL<%= @event.service_level %>
40-
</span>
41-
<% end %>
42-
43-
<%= render "events/follow_button", event: @event, event_follow: @event_follow %>
44-
</h1>
30+
<%= render "events/heading", event: @event, event_follow: @event_follow do %>
31+
<span class="flex-grow">Home</span>
32+
<% end %>
4533

4634
<div class="flex flex-col gap-[20px] -mt-3" data-controller="event-home">
4735
<% if organizer_signed_in?(as: :member) %>

app/views/events/transactions.html.erb

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -27,35 +27,9 @@
2727

2828
<%= render "events/nav", selected: :transactions %>
2929

30-
<%# Demo mode callout thing %>
31-
<% if organizer_signed_in? && @event.demo_mode && !Flipper.enabled?(:event_home_page_redesign_2024_09_21, @event) %>
32-
<div class="mt-4 card border pb0 mb-4" style="text-wrap: pretty;" id="playground-callout" data-tour-step="playground_mode">
33-
<p class="mt0">
34-
<strong>Welcome to Playground Mode</strong>
35-
<br>
36-
While in Playground mode, explore the dashboard with mock data, and invite your team.
37-
</p>
38-
39-
<%= link_to({ show_mock_data: !show_mock_data? }, class: "btn btn-small mb-4 w-fit shrink-none nowrap") do %>
40-
<%= inline_icon "view" %>
41-
<%= show_mock_data? ? "Hide" : "Show" %> mock data
42-
<% end %>
43-
</div>
44-
<% end %>
45-
46-
<h1 class="flex items-center flex-wrap mb-0 border-0">
30+
<%= render "events/heading", event: @event, event_follow: @event_follow do %>
4731
<span class="flex-grow">Transactions</span>
48-
<% admin_tool("p0 m2 my-0 badge bg-transparent", "span") do %>
49-
<span class="m0 badge bg-muted">
50-
#<%= @event.id %>
51-
</span>
52-
<span class="m0 badge bg-muted ml1">
53-
SL<%= @event.service_level %>
54-
</span>
55-
<% end %>
56-
57-
<%= render "events/follow_button", event: @event, event_follow: @event_follow %>
58-
</h1>
32+
<% end %>
5933

6034
<div class="statset mb-2">
6135
<div class="stat">

0 commit comments

Comments
 (0)