Skip to content

Commit 832292d

Browse files
committed
fix(test): include TextRecognitionResult in is_valid_display_result
The helper allow-list pre-dated the text-recognition result type, so any text-rec IQ surfaced by list_image_queries failed the assertion in test_list_image_queries. Same shape of test fragility was failing on main already; including TextRecognitionResult clears it.
1 parent 7c8400c commit 832292d

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

test/integration/test_groundlight.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
MultiClassificationResult,
2626
PaginatedDetectorList,
2727
PaginatedImageQueryList,
28+
TextRecognitionResult,
2829
)
2930
from urllib3.exceptions import ConnectTimeoutError, MaxRetryError, ReadTimeoutError
3031
from urllib3.util.retry import Retry
@@ -37,11 +38,9 @@
3738

3839
def is_valid_display_result(result: Any) -> bool:
3940
"""Is the image query result valid to display to the user?."""
40-
if (
41-
not isinstance(result, BinaryClassificationResult)
42-
and not isinstance(result, CountingResult)
43-
and not isinstance(result, MultiClassificationResult)
44-
and not isinstance(result, BoundingBoxResult)
41+
if not isinstance(
42+
result,
43+
(BinaryClassificationResult, CountingResult, MultiClassificationResult, BoundingBoxResult, TextRecognitionResult),
4544
):
4645
return False
4746

0 commit comments

Comments
 (0)